Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(goal_planner): rename shoulder_lane to pull_over_lane #9422

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Nov 21, 2024

Description

This PR is just renaming variables

goal planner supports pull over on road_lane not only shoulder_lane(subtype: road_shoulder).
so, pull_over_lane for the variable name.
pull_over_lanes means both road_lanes and shoulder_lanes

Related links

Parent Issue:

  • Link

How was this PR tested?

2024/11/21 https://evaluation.tier4.jp/evaluation/reports/64f8a2e9-8987-5182-add7-7aee9d1b2722/?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 marked this pull request as ready for review November 21, 2024 09:43
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 21, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 28.95%. Comparing base (d8087f4) to head (0a47c11).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...r_module/src/pull_over_planner/shift_pull_over.cpp 0.00% 3 Missing ⚠️
...s/parking_departure/geometric_parallel_parking.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9422      +/-   ##
==========================================
- Coverage   28.96%   28.95%   -0.02%     
==========================================
  Files        1427     1433       +6     
  Lines      108253   108296      +43     
  Branches    41398    41399       +1     
==========================================
  Hits        31352    31352              
- Misses      73866    73909      +43     
  Partials     3035     3035              
Flag Coverage Δ *Carryforward flag
differential 19.99% <0.00%> (?)
total 28.96% <ø> (+<0.01%) ⬆️ Carriedforward from d8087f4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@kosuke55 kosuke55 merged commit 60dbc46 into autowarefoundation:main Nov 21, 2024
45 of 46 checks passed
@kosuke55 kosuke55 deleted the refactor/rename_shoulder_lane branch November 21, 2024 10:51
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2024
TetsuKawa pushed a commit to tier4/autoware.universe that referenced this pull request Dec 1, 2024
TetsuKawa added a commit to tier4/autoware.universe that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants