Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(control_performance_analysis): clang-diagnostic-pessimizing-move #9380

Merged

fix(control_performance_analysis): clang-diagnostic-pessimizing-move

5a0fcc0
Select commit
Loading
Failed to load commit list.
Merged

fix(control_performance_analysis): clang-diagnostic-pessimizing-move #9380

fix(control_performance_analysis): clang-diagnostic-pessimizing-move
5a0fcc0
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Nov 19, 2024 in 37s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.00 (8.70 -> 8.70)

  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Large Method control_performance_analysis_core.cpp: ControlPerformanceAnalysisCore::calculateDrivingVars

Annotations

Check notice on line 338 in control/control_performance_analysis/src/control_performance_analysis_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Large Method

ControlPerformanceAnalysisCore::calculateDrivingVars decreases from 75 to 74 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.