Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: suppress warning/error of the empty predicted trajectory by MPC #9373

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Nov 19, 2024

Description

The empty predicted trajectory is intended when the MPC is in an emergency such as too large deviation from the planning trajectory.
Based on this specification, I changed the logger level of the error/warn messages for the predicted trajectory since they fill the terminal.

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Nov 19, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29.65%. Comparing base (b4603fd) to head (adcac77).
Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
...toware_control_validator/src/control_validator.cpp 0.00% 1 Missing ⚠️
...rture_checker_node/lane_departure_checker_node.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9373      +/-   ##
==========================================
- Coverage   29.66%   29.65%   -0.01%     
==========================================
  Files        1338     1344       +6     
  Lines      103204   103249      +45     
  Branches    40216    40219       +3     
==========================================
+ Hits        30611    30615       +4     
- Misses      69638    69679      +41     
  Partials     2955     2955              
Flag Coverage Δ *Carryforward flag
differential 22.44% <0.00%> (?)
total 29.66% <ø> (+<0.01%) ⬆️ Carriedforward from b4603fd

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@takayuki5168 takayuki5168 merged commit a7cc44d into autowarefoundation:main Nov 19, 2024
45 of 46 checks passed
@takayuki5168 takayuki5168 deleted the fix/suppress-predicted-trajectory-warning branch November 19, 2024 12:23
zulfaqar-azmi-t4 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants