Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goal_planner)!: remove stop reason #9365

Merged

Conversation

satoshi-ota
Copy link
Contributor

Description

Don't use stop reason. This module uses velocity factor instead of it.

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 18, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 25, 2024
@satoshi-ota satoshi-ota enabled auto-merge (squash) November 25, 2024 05:47
@soblin soblin changed the title fix(goal_planner): remove stop reason fix(goal_planner)!: remove stop reason Nov 25, 2024
@satoshi-ota satoshi-ota merged commit 882af41 into autowarefoundation:main Nov 25, 2024
37 of 38 checks passed
@satoshi-ota satoshi-ota deleted the fix/remove-stop-reason-goal branch November 25, 2024 06:07
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.76%. Comparing base (24652f8) to head (a646416).
Report is 66 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9365      +/-   ##
==========================================
- Coverage   29.78%   29.76%   -0.02%     
==========================================
  Files        1338     1343       +5     
  Lines      103302   103364      +62     
  Branches    40240    40241       +1     
==========================================
  Hits        30770    30770              
- Misses      69547    69609      +62     
  Partials     2985     2985              
Flag Coverage Δ *Carryforward flag
differential 0.52% <ø> (?)
total 29.78% <ø> (+<0.01%) ⬆️ Carriedforward from 24652f8

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants