Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(static_obstacle_avoidance): remove redundant calculation related to lanelet functions #9355

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

go-sakayori
Copy link
Contributor

@go-sakayori go-sakayori commented Nov 18, 2024

Description

This PR removes redundant calculation of lanelet related funtions, by adding substituting the result in AvoidancePlanningData .
Especially the below two results are tackled in this Pr.

  • getClosestLanelet
  • calcDistanceToRedTrafficLight
  • isAllowedGoalModification

Related links

None

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 18, 2024
Copy link

github-actions bot commented Nov 18, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
@go-sakayori go-sakayori added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 14 lines in your changes missing coverage. Please review.

Project coverage is 29.81%. Comparing base (4cb6f10) to head (1494a6a).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ath_static_obstacle_avoidance_module/src/utils.cpp 10.00% 3 Missing and 6 partials ⚠️
...ath_static_obstacle_avoidance_module/src/scene.cpp 69.23% 2 Missing and 2 partials ⚠️
...r_path_static_obstacle_avoidance_module/helper.hpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9355      +/-   ##
==========================================
- Coverage   29.81%   29.81%   -0.01%     
==========================================
  Files        1338     1341       +3     
  Lines      103242   103261      +19     
  Branches    40238    40238              
==========================================
+ Hits        30783    30786       +3     
- Misses      69472    69488      +16     
  Partials     2987     2987              
Flag Coverage Δ *Carryforward flag
differential 21.45% <46.15%> (?)
total 29.81% <ø> (-0.01%) ⬇️ Carriedforward from 4cb6f10

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@go-sakayori go-sakayori merged commit d813446 into autowarefoundation:main Nov 18, 2024
43 of 44 checks passed
@go-sakayori go-sakayori deleted the refactor/soa branch November 18, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants