feat(mrm_comfortable_stop_operator): add updateParam for mrm comfortable stop #9353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran
requested review from
mkuri and
TomohitoAndo
as code owners
github-actions
bot
added
the
component:system
danielsanchezaran
added
run:build-and-test-differential
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9353 +/- ##
==========================================
- Coverage 29.81% 29.81% -0.01%
==========================================
Files 1338 1339 +1
Lines 103242 103264 +22
Branches 40238 40240 +2
==========================================
Hits 30783 30783
- Misses 69472 69494 +22
Partials 2987 2987
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
the
component:system
...table_stop_operator/src/mrm_comfortable_stop_operator/mrm_comfortable_stop_operator_core.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
mkuri
approved these changes
Nov 18, 2024
danielsanchezaran
deleted the
feat/add-param-update-to-mrm-comfortable-stop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add updateParam to facilitate comfortable stop param tuning and avoid relaunching autoware to test new params
Note: I did not add the option to change the Hz of the module since I believe that might cause some troubles and it is best to not change it while Autoware is running
Related links
Parent Issue:
How was this PR tested?
PSim
cap-.2024-11-18-13-52-41.mp4
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.