Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(factor): move steering factor interface to motion utils #9337

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Nov 15, 2024

Description

Move steering factor interface to autoware_motion_utils from bpp package so that the other modules can use it.

Related links

Parent Issue:

  • Link

How was this PR tested?

  • Psim
  • PASS TIER IV INTERNAL SCENARIOS

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Nov 15, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 17, 2024
@satoshi-ota satoshi-ota enabled auto-merge (squash) November 17, 2024 23:10
@satoshi-ota satoshi-ota merged commit 6f40830 into autowarefoundation:main Nov 18, 2024
39 of 40 checks passed
@satoshi-ota satoshi-ota deleted the refactor/move-common branch November 18, 2024 00:06
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.81%. Comparing base (d819a66) to head (0c2d614).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9337   +/-   ##
=======================================
  Coverage   29.81%   29.81%           
=======================================
  Files        1338     1339    +1     
  Lines      103200   103220   +20     
  Branches    40208    40209    +1     
=======================================
+ Hits        30774    30780    +6     
- Misses      69437    69452   +15     
+ Partials     2989     2988    -1     
Flag Coverage Δ *Carryforward flag
differential 30.63% <ø> (?)
total 29.81% <ø> (ø) Carriedforward from d819a66

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants