Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_traffic_light_multi_camera_fusion): resolve clang-tidy error #9336

Conversation

yhisaki
Copy link
Contributor

@yhisaki yhisaki commented Nov 15, 2024

Description

Fixed clang-tidy errors.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…error

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Nov 15, 2024
Copy link

github-actions bot commented Nov 15, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@yhisaki yhisaki added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.81%. Comparing base (d819a66) to head (a325c0b).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9336      +/-   ##
==========================================
- Coverage   29.81%   29.81%   -0.01%     
==========================================
  Files        1338     1338              
  Lines      103200   103146      -54     
  Branches    40208    40190      -18     
==========================================
- Hits        30774    30753      -21     
+ Misses      69437    69408      -29     
+ Partials     2989     2985       -4     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 29.81% <ø> (-0.01%) ⬇️ Carriedforward from 43d94eb

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Copy link
Contributor

@MasatoSaeki MasatoSaeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I checked correct behavior on DLR.

@yhisaki yhisaki merged commit 5dcb52b into autowarefoundation:main Nov 18, 2024
31 of 32 checks passed
@yhisaki yhisaki deleted the resolve-clang-tidy-autoware_traffic_light_multi_camera_fusion branch November 18, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants