Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(crosswalk)!: delete wide crosswalk corresponding function #9329

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Nov 15, 2024

Description

The current crosswalk module has a feature to handle wide width crosswalk.
However, such use cases are rare against our maintenance cost.

Therefore, I propose to delete this function.

Related links

launch PR: autowarefoundation/autoware_launch#1233

How was this PR tested?

psim and tier4 scenario tests

Notes for reviewers

Interface changes

Effects on system behavior

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@yuki-takagi-66 yuki-takagi-66 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 15, 2024
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review November 15, 2024 06:13
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 15, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.64%. Comparing base (cdb6e88) to head (d7ccd31).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
..._velocity_crosswalk_module/src/scene_crosswalk.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9329      +/-   ##
==========================================
- Coverage   29.66%   29.64%   -0.02%     
==========================================
  Files        1338     1343       +5     
  Lines      103204   103252      +48     
  Branches    40216    40215       -1     
==========================================
- Hits        30615    30614       -1     
- Misses      69633    69682      +49     
  Partials     2956     2956              
Flag Coverage Δ *Carryforward flag
differential 19.21% <0.00%> (?)
total 29.66% <ø> (-0.01%) ⬇️ Carriedforward from cdb6e88

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuki-takagi-66 yuki-takagi-66 merged commit fbf297a into autowarefoundation:main Nov 15, 2024
47 of 48 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the takagi/crosswalk/delete-wide-crosswalk-feature branch November 15, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants