Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bpp): rework steering factor interface #9325

Merged
merged 9 commits into from
Nov 15, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Nov 14, 2024

Description

As with bvp, the implementation was changed so that the sub-manager holds publisher of steering factor and each module only sets the factor.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 14, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@go-sakayori go-sakayori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for static obstacle avoidance

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 32.69231% with 35 lines in your changes missing coverage. Please review.

Project coverage is 29.28%. Comparing base (7528c47) to head (bc71393).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...common/src/interface/steering_factor_interface.cpp 0.00% 7 Missing ⚠️
...ommon/interface/scene_module_manager_interface.hpp 33.33% 5 Missing and 1 partial ⚠️
..._start_planner_module/src/start_planner_module.cpp 0.00% 5 Missing ⚠️
...or_path_planner/src/behavior_path_planner_node.cpp 50.00% 2 Missing and 1 partial ⚠️
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 2 Missing ⚠️
...behavior_path_lane_change_module/src/interface.cpp 0.00% 2 Missing ⚠️
...or_path_static_obstacle_avoidance_module/scene.hpp 0.00% 2 Missing ⚠️
...path_dynamic_obstacle_avoidance_module/manager.hpp 0.00% 1 Missing ⚠️
...th_dynamic_obstacle_avoidance_module/src/scene.cpp 0.00% 1 Missing ⚠️
..._behavior_path_goal_planner_module/src/manager.cpp 0.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9325      +/-   ##
==========================================
- Coverage   29.30%   29.28%   -0.02%     
==========================================
  Files        1334     1340       +6     
  Lines      102801   102840      +39     
  Branches    39975    39973       -2     
==========================================
- Hits        30124    30117       -7     
- Misses      69710    69754      +44     
- Partials     2967     2969       +2     
Flag Coverage Δ *Carryforward flag
differential 19.48% <32.69%> (?)
total 29.29% <ø> (-0.01%) ⬇️ Carriedforward from 7528c47

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit d819a66 into autowarefoundation:main Nov 15, 2024
56 of 58 checks passed
@satoshi-ota satoshi-ota deleted the refactor/steering-factor branch November 15, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants