Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(bpp_common): add tests for the static drivable area #9324

Merged
merged 13 commits into from
Nov 15, 2024
Merged

test(bpp_common): add tests for the static drivable area #9324

merged 13 commits into from
Nov 15, 2024

Conversation

maxime-clem
Copy link
Contributor

Description

Add tests for some of the static drivable area functions.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@maxime-clem
add test for getOverlappedLaneletId
f17fbf8 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
add tests for cutOverlappedLanes
7b2258c 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
add tests for generateDrivableLanes
c65eba9 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
add test for generateDrivableArea
724deda 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
add test for getBoundWithIntersectionAreas
fbfe355 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
add test for combineDrivableAreaInfo
4e38960 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
add test for generateDrivableArea
2f05195 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 14, 2024
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@maxime-clem
disable test where the generated right bound crosses the path
2c397b1 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.41%. Comparing base (70b6f19) to head (9d301f6).
Report is 40 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9324      +/-   ##
==========================================
+ Coverage   29.24%   29.41%   +0.16%     
==========================================
  Files        1335     1339       +4     
  Lines      102954   102992      +38     
  Branches    39937    39943       +6     
==========================================
+ Hits        30114    30298     +184     
+ Misses      69920    69747     -173     
- Partials     2920     2947      +27
Flag Coverage Δ *Carryforward flag
differential 29.73% <100.00%> (?)
total 29.24% <ø> (-0.01%) ⬇️ Carriedforward from 10aa504

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem
fix small typo (laneles -> lanelets)
10aa504 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem marked this pull request as ready for review November 15, 2024 00:16
go-sakayori
go-sakayori approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@go-sakayori go-sakayori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think EXPECT_DOUBLE_EQ should be preferred than EXPECT_EQ in some cases, but rather than that it LGTM.

...havior_path_planner/autoware_behavior_path_planner_common/test/test_static_drivable_area.cpp Outdated Show resolved Hide resolved
@maxime-clem
change EXPECT_EQ to EXPECT_DOUBLE_EQ when comparing double
cf0f2e2 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
add some comments
80aa2cc 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
simplify make_drivable_lanes
549f706 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
move make_lanelet function to autoware_test_utils
9d301f6 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Nov 15, 2024
zulfaqar-azmi-t4
zulfaqar-azmi-t4 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maxime-clem maxime-clem merged commit e54020e into autowarefoundation:main Nov 15, 2024
31 of 32 checks passed
@maxime-clem maxime-clem deleted the test/static_drivable_area branch November 15, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 zulfaqar-azmi-t4 approved these changes

@go-sakayori go-sakayori go-sakayori approved these changes

@danielsanchezaran danielsanchezaran Awaiting requested review from danielsanchezaran danielsanchezaran is a code owner

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@soblin soblin Awaiting requested review from soblin soblin is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxime-clem @go-sakayori @zulfaqar-azmi-t4