Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run_out): output velocity factor #9319

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

satoshi-ota
Copy link
Contributor

Description

Set velocity factor when run out module inserts stop point.

Screenshot from 2024-11-14 11-29-49

Related links

Parent Issue:

  • Link

How was this PR tested?

Psim

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota marked this pull request as ready for review November 14, 2024 02:35
@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) labels Nov 14, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@danielsanchezaran danielsanchezaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 29.30%. Comparing base (6a1ddbd) to head (9067788).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...are_behavior_velocity_run_out_module/src/scene.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9319      +/-   ##
==========================================
- Coverage   29.31%   29.30%   -0.01%     
==========================================
  Files        1334     1336       +2     
  Lines      102800   102840      +40     
  Branches    39984    39989       +5     
==========================================
+ Hits        30136    30139       +3     
- Misses      69797    69834      +37     
  Partials     2867     2867              
Flag Coverage Δ *Carryforward flag
differential 18.03% <0.00%> (?)
total 29.31% <ø> (ø) Carriedforward from 6a1ddbd

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit 7eec0bb into autowarefoundation:main Nov 14, 2024
42 checks passed
@satoshi-ota satoshi-ota deleted the fix/run-out-factor branch November 14, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants