Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hazard_status_converter): hazard status converter subscribe emergency holding #9287

Conversation

TetsuKawa
Copy link
Contributor

@TetsuKawa TetsuKawa commented Nov 11, 2024

Description

This PR add emergency holding subscriber and update emergency_holding which is in hazard_status topic .

Related links

Parent Issue:

How was this PR tested?

Please refer to the parent PR.

Notes for reviewers

None.

Interface changes

Topic changes

Additions and removals

Change type Topic Type Topic Name Message Type Description
Added Sub /system/emergency_holding tier4_system_msgs/msg/EmergencyHoldingState indicates whether mrm is in the emergency_holding state

Effects on system behavior

None.

@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Nov 11, 2024
Copy link

github-actions bot commented Nov 11, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@TetsuKawa TetsuKawa changed the title Feat/hazard status converter subscribe emergency holding feat(hazard_status_converter): hazard status converter subscribe emergency holding Nov 11, 2024
@TetsuKawa TetsuKawa self-assigned this Nov 11, 2024
@TetsuKawa TetsuKawa marked this pull request as ready for review November 11, 2024 06:45
@TetsuKawa TetsuKawa added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 11, 2024
Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 29.15%. Comparing base (7528c47) to head (d1c3dd9).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
system/hazard_status_converter/src/converter.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9287      +/-   ##
==========================================
- Coverage   29.30%   29.15%   -0.16%     
==========================================
  Files        1334     1335       +1     
  Lines      102801   102813      +12     
  Branches    39975    39826     -149     
==========================================
- Hits        30124    29973     -151     
- Misses      69710    69898     +188     
+ Partials     2967     2942      -25     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.15% <ø> (-0.15%) ⬇️ Carriedforward from 3d81786

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

TetsuKawa and others added 4 commits November 14, 2024 18:54
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
@TetsuKawa TetsuKawa force-pushed the feat/hazard_status_converter_subscribe_emergency_holding branch from 9f28f4f to 3d81786 Compare November 14, 2024 09:55
@TetsuKawa TetsuKawa merged commit 827a5d9 into autowarefoundation:main Nov 14, 2024
32 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Nov 14, 2024
…gency holding (autowarefoundation#9287)

* feat: add subscriber for emergency_holding

Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>

* modify: fix value name

Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>

* style(pre-commit): autofix

Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>

* feat: add const to is_emergency_holding

Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>

---------

Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants