-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hazard_status_converter): hazard status converter subscribe emergency holding #9287
feat(hazard_status_converter): hazard status converter subscribe emergency holding #9287
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9287 +/- ##
==========================================
- Coverage 29.30% 29.15% -0.16%
==========================================
Files 1334 1335 +1
Lines 102801 102813 +12
Branches 39975 39826 -149
==========================================
- Hits 30124 29973 -151
- Misses 69710 69898 +188
+ Partials 2967 2942 -25
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
9f28f4f
to
3d81786
Compare
…gency holding (autowarefoundation#9287) * feat: add subscriber for emergency_holding Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * modify: fix value name Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * style(pre-commit): autofix Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * feat: add const to is_emergency_holding Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> --------- Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Description
This PR add emergency holding subscriber and update
emergency_holding
which is inhazard_status
topic .Related links
Parent Issue:
How was this PR tested?
Please refer to the parent PR.
Notes for reviewers
None.
Interface changes
Topic changes
Additions and removals
/system/emergency_holding
tier4_system_msgs/msg/EmergencyHoldingState
Effects on system behavior
None.