-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(fake_test_node): prefix package and namespace with autoware #9249
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
4fa04dc
to
bd9f827
Compare
common/autoware_fake_test_node/include/fake_test_node/fake_test_node.hpp
Outdated
Show resolved
Hide resolved
f9189f0
to
50655b5
Compare
@maxime-clem thanks for the review. @xmfcx can you merge this? Thanks. |
CI has failed. |
50655b5
to
6daea4b
Compare
It seems to have failed again. |
6daea4b
to
cc4fc18
Compare
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
cc4fc18
to
5f26dfe
Compare
@xmfcx sorry for all the back and forth, I've built this branch locally and the build passes. Hopefully CI passes as well. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9249 +/- ##
==========================================
- Coverage 29.31% 29.30% -0.02%
==========================================
Files 1334 1342 +8
Lines 102800 102886 +86
Branches 39984 40007 +23
==========================================
+ Hits 30136 30148 +12
- Misses 69797 69864 +67
- Partials 2867 2874 +7
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…utowarefoundation#9249) Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Description
prefix package and namespace with
autoware
Related links
Parent Issue:
autoware.universe/common
packages autoware#5077How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.