Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fake_test_node): prefix package and namespace with autoware #9249

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Nov 6, 2024

Description

prefix package and namespace with autoware

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@esteve esteve added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 6, 2024
@esteve esteve self-assigned this Nov 6, 2024
@esteve esteve marked this pull request as ready for review November 6, 2024 13:01
@esteve esteve enabled auto-merge (squash) November 6, 2024 13:01
@esteve esteve force-pushed the prefix-fake_test_node branch from 4fa04dc to bd9f827 Compare November 6, 2024 13:01
@esteve esteve force-pushed the prefix-fake_test_node branch 2 times, most recently from f9189f0 to 50655b5 Compare November 13, 2024 10:46
@esteve
Copy link
Contributor Author

esteve commented Nov 13, 2024

@maxime-clem thanks for the review.

@xmfcx can you merge this? Thanks.

@xmfcx xmfcx disabled auto-merge November 13, 2024 11:53
@xmfcx
Copy link
Contributor

xmfcx commented Nov 13, 2024

https://github.com/autowarefoundation/autoware.universe/actions/runs/11815670194/job/32917329699?pr=9249#step:5:13854

/__w/autoware.universe/autoware.universe/common/autoware_fake_test_node/test/test_fake_test_node.cpp:33:35: error: ‘tools’ in namespace ‘autoware’ does not name a type
   33 | using FakeNodeFixture = autoware::tools::testing::FakeTestNode;
      |                                   ^~~~~

CI has failed.

@esteve esteve force-pushed the prefix-fake_test_node branch from 50655b5 to 6daea4b Compare November 13, 2024 12:42
@esteve
Copy link
Contributor Author

esteve commented Nov 13, 2024

@xmfcx fixed in 6daea4b

@xmfcx
Copy link
Contributor

xmfcx commented Nov 13, 2024

https://github.com/autowarefoundation/autoware.universe/actions/runs/11817499038/job/32923033722?pr=9249#step:5:20296

CMake Error at /__w/autoware.universe/autoware.universe/install/ament_cmake_target_dependencies/share/ament_cmake_target_dependencies/cmake/ament_target_dependencies.cmake:77 (message):
  ament_target_dependencies() the passed package name 'fake_test_node' was
  not found before
Call Stack (most recent call first):
  CMakeLists.txt:36 (ament_target_dependencies)

It seems to have failed again.

@esteve esteve force-pushed the prefix-fake_test_node branch from 6daea4b to cc4fc18 Compare November 13, 2024 14:28
@esteve esteve marked this pull request as draft November 13, 2024 14:40
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve esteve force-pushed the prefix-fake_test_node branch from cc4fc18 to 5f26dfe Compare November 13, 2024 14:44
@esteve esteve marked this pull request as ready for review November 13, 2024 14:52
@esteve
Copy link
Contributor Author

esteve commented Nov 13, 2024

@xmfcx sorry for all the back and forth, I've built this branch locally and the build passes. Hopefully CI passes as well.

@esteve esteve enabled auto-merge (squash) November 13, 2024 14:54
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.30%. Comparing base (6a1ddbd) to head (5f26dfe).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9249      +/-   ##
==========================================
- Coverage   29.31%   29.30%   -0.02%     
==========================================
  Files        1334     1342       +8     
  Lines      102800   102886      +86     
  Branches    39984    40007      +23     
==========================================
+ Hits        30136    30148      +12     
- Misses      69797    69864      +67     
- Partials     2867     2874       +7     
Flag Coverage Δ *Carryforward flag
differential 20.98% <ø> (?)
total 29.29% <ø> (-0.02%) ⬇️ Carriedforward from e0002f3

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xmfcx xmfcx disabled auto-merge November 14, 2024 11:58
@xmfcx xmfcx merged commit a59d309 into autowarefoundation:main Nov 14, 2024
32 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Nov 14, 2024
@esteve esteve deleted the prefix-fake_test_node branch November 18, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants