fix(autoware_behavior_path_sampling_planner_module): fix invalid parameter file #9231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meter file Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
mitsudome-r
requested review from
danielsanchezaran and
maxime-clem
as code owners
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
mitsudome-r
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9231 +/- ##
==========================================
- Coverage 29.81% 28.39% -1.43%
==========================================
Files 1338 1324 -14
Lines 103301 102996 -305
Branches 40233 39881 -352
==========================================
- Hits 30797 29243 -1554
- Misses 69518 70750 +1232
- Partials 2986 3003 +17
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
youtalk
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
I've check the sampling_planner.param.yaml in awf/autoware_launch. They are exactly the same.
|
@danielsanchezaran @maxime-clem Please review this. It has no side effect. |
maxime-clem
approved these changes
Nov 19, 2024
zulfaqar-azmi-t4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 21, 2024
…meter file (autowarefoundation#9231) Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm trying to see if I can make tier4_planning_launch able to launch without calling it from autoware_launch as a standalone launch file.
Through the process, I found out that the sample parameter file provided in the autoware_behavior_path_sampling_planner_module package was broken.
This copies the file from autoware_launch file so that people can use it as a default parameter setup.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.