Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): add unit test for normal lane change class (RT1-7970) #9090

Merged

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Oct 16, 2024

Description

Add simple test for normal lane change class.

Local coverage result before PR

screenshot-20241018-062915Z

Local coverage result after PR

screenshot-20241018-062602Z

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 16, 2024
Copy link

github-actions bot commented Oct 16, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the RT1-7970-testing-base-class branch 3 times, most recently from 1a69cd2 to 152b355 Compare October 17, 2024 09:33
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the RT1-7970-testing-base-class branch from b881f48 to 0c0b1ef Compare October 18, 2024 06:23
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 changed the title RT1-7970 testing base class feat(lane_change): add unit test for normal lane change class (RT1-7970) Oct 18, 2024
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 marked this pull request as ready for review October 18, 2024 06:31
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 28.20%. Comparing base (92868c0) to head (0e362e6).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...e_behavior_path_planner_common/src/utils/utils.cpp 20.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9090      +/-   ##
==========================================
+ Coverage   27.50%   28.20%   +0.69%     
==========================================
  Files        1303     1309       +6     
  Lines      101046   101097      +51     
  Branches    39180    39183       +3     
==========================================
+ Hits        27794    28514     +720     
+ Misses      70544    69730     -814     
- Partials     2708     2853     +145     
Flag Coverage Δ *Carryforward flag
differential 18.57% <60.00%> (?)
total 27.50% <ø> (-0.01%) ⬇️ Carriedforward from 5e25256

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Copy link
Contributor

@mkquda mkquda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 enabled auto-merge (squash) October 21, 2024 01:10
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 20ebe9d into autowarefoundation:main Oct 21, 2024
24 of 26 checks passed
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the RT1-7970-testing-base-class branch October 21, 2024 01:38
zulfaqar-azmi-t4 added a commit to tier4/autoware.universe that referenced this pull request Dec 20, 2024
…70) (autowarefoundation#9090)

* RT1-7970 testing base class

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* additional test

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Added update lanes

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* check path generation

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* check is lane change required

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix PRs comment

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request Dec 20, 2024
…70) (autowarefoundation#9090)

* RT1-7970 testing base class

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* additional test

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Added update lanes

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* check path generation

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* check is lane change required

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix PRs comment

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request Dec 21, 2024
…70) (autowarefoundation#9090)

* RT1-7970 testing base class

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* additional test

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Added update lanes

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* check path generation

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* check is lane change required

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix PRs comment

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants