fix(crosswalk): fix passing direction calclation for the objects #9071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
yuki-takagi-66
changed the title
yuki-takagi-66
changed the title
yuki-takagi-66
requested review from
kyoichi-sugahara,
soblin,
satoshi-ota,
shmpwk,
takayuki5168 and
tkimura4
as code owners
yuki-takagi-66
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9071 +/- ##
==========================================
- Coverage 26.77% 26.76% -0.02%
==========================================
Files 1296 1301 +5
Lines 95822 95868 +46
Branches 39145 39146 +1
==========================================
+ Hits 25657 25658 +1
- Misses 67518 67563 +45
Partials 2647 2647
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yuki-takagi-66
changed the title
soblin
approved these changes
Oct 11, 2024
yuki-takagi-66
merged commit d01ae0d
into
autowarefoundation:main
52 of 54 checks passed
kyoichi-sugahara
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 19, 2024
…owarefoundation#9071) Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the crosswalk width is narrow than sparse_resample_interval, which is had coded as 4.0m, passing direction calculation may failed because idx1 == idx2 is satisfied.
This PR fix this issue, and now both of the same directional objects and the opposite directional objects are ignored as a crosswalk user.
Related links
#5849
How was this PR tested?
scenario tests
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.