Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(system_monitor): add on/off config for network traffic monitor #9069

Merged

fix: change function name from stop to skip

fad266d
Select commit
Loading
Failed to load commit list.
Merged

feat(system_monitor): add on/off config for network traffic monitor #9069

fix: change function name from stop to skip
fad266d
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Nov 7, 2024 in 57s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.01 (8.68 -> 8.69)

View detailed results in CodeScene

Details

Annotations

Check notice on line 278 in system/system_monitor/src/net_monitor/net_monitor.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Bumpy Road Ahead

NetMonitor::monitor_traffic increases from 2 to 3 logical blocks with deeply nested code, threshold is one single block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check notice on line 278 in system/system_monitor/src/net_monitor/net_monitor.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Deep, Nested Complexity

NetMonitor::monitor_traffic increases in nested complexity depth from 4 to 5, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.