Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tier4_perception_launch): remove duplicated parameter declaration #9031

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Oct 4, 2024

Description

  • Remove duplicated parameters declaration in launch.py files to avoid maintenance cost.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…tion

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Oct 4, 2024
@badai-nguyen badai-nguyen added perception and removed component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Oct 4, 2024
Copy link

github-actions bot commented Oct 4, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@badai-nguyen badai-nguyen added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed perception labels Oct 4, 2024
@badai-nguyen badai-nguyen marked this pull request as ready for review October 4, 2024 07:06
@github-actions github-actions bot added component:launch Launch files, scripts and initialization tools. (auto-assigned) and removed component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Oct 4, 2024
@badai-nguyen
Copy link
Contributor Author

@YoshiRi @technolojin Could you review this small refactor PR?

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen badai-nguyen merged commit 1e26395 into autowarefoundation:main Oct 4, 2024
26 of 28 checks passed
prakash-kannaiah pushed a commit to prakash-kannaiah/autoware.universe that referenced this pull request Oct 9, 2024
…ation (autowarefoundation#9031)

Signed-off-by: prakash-kannaiah <prakashkanan.pk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants