Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autonomous_emergency_braking): add sanity chackes #8998

Merged

Conversation

danielsanchezaran
Copy link
Contributor

@danielsanchezaran danielsanchezaran commented Oct 1, 2024

Description

Some sanity checks for empty paths/vectors

Related links

Parent Issue:

  • Link

How was this PR tested?

PSim

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@danielsanchezaran danielsanchezaran marked this pull request as ready for review October 1, 2024 08:56
@danielsanchezaran danielsanchezaran added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 1, 2024
@kyoichi-sugahara kyoichi-sugahara self-assigned this Oct 1, 2024
Copy link
Contributor

@Owen-Liuyuxuan Owen-Liuyuxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update builds and works in my local environment on the originally failed scenario. Thank you.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 28.02%. Comparing base (9f7ba86) to head (5b76cd5).
Report is 48 commits behind head on main.

Files with missing lines Patch % Lines
...autoware_autonomous_emergency_braking/src/node.cpp 0.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8998      +/-   ##
==========================================
- Coverage   28.02%   28.02%   -0.01%     
==========================================
  Files        1316     1317       +1     
  Lines       98601    98631      +30     
  Branches    39771    39777       +6     
==========================================
+ Hits        27636    27639       +3     
- Misses      70819    70844      +25     
- Partials      146      148       +2     
Flag Coverage Δ *Carryforward flag
differential 6.83% <0.00%> (?)
total 28.02% <ø> (+<0.01%) ⬆️ Carriedforward from 9f7ba86

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielsanchezaran danielsanchezaran merged commit a301539 into autowarefoundation:main Oct 1, 2024
43 of 44 checks passed
@danielsanchezaran danielsanchezaran deleted the feat/add-aeb-sanity-checks branch October 1, 2024 09:19
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Oct 1, 2024
…ation#8998)

add sanity chackes

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Oct 1, 2024
…ation#8998) (#1570)

add sanity chackes

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Oct 3, 2024
…ation#8998)

add sanity chackes

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Oct 3, 2024
…ation#8998)

add sanity chackes

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Oct 4, 2024
…ion#8998) (#1573)

feat(autonomous_emergency_braking): add sanity chackes (autowarefoundation#8998)

add sanity chackes

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
prakash-kannaiah pushed a commit to prakash-kannaiah/autoware.universe that referenced this pull request Oct 9, 2024
…ation#8998)

add sanity chackes

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: prakash-kannaiah <prakashkanan.pk@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Oct 28, 2024
…ation#8998)

add sanity chackes

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Nov 14, 2024
…ation#8998)

add sanity chackes

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants