Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(system_error_monitor): remove system error monitor #8929

Merged
merged 3 commits into from
Sep 24, 2024
Merged

feat(system_error_monitor): remove system error monitor #8929

merged 3 commits into from
Sep 24, 2024

Conversation

TetsuKawa
Copy link
Contributor

@TetsuKawa TetsuKawa commented Sep 20, 2024 •
edited
Loading

Description

remove system_error_monitor package and relevant parts.

Related links

autoware_launch PR

How was this PR tested?

Comfirmed no problem in launching Psim or Lsim.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@TetsuKawa
feat: delete-system-error-monitor-from-autoware
c697a56 
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:system System design and integration. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Sep 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@TetsuKawa TetsuKawa changed the title feat(system_error_monitor): delete-system-error-monitor feat(system_error_monitor): remove-system-error-monitor Sep 20, 2024
@TetsuKawa TetsuKawa mentioned this pull request Sep 20, 2024
Merged
7 tasks
@TetsuKawa TetsuKawa marked this pull request as ready for review September 20, 2024 09:40
@TetsuKawa TetsuKawa changed the title feat(system_error_monitor): remove-system-error-monitor feat(system_error_monitor): remove system error monitor Sep 20, 2024
ito-san
ito-san approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ito-san ito-san added type:improvement Proposed enhancement run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Sep 24, 2024
@ito-san ito-san enabled auto-merge (squash) September 24, 2024 00:41
@codecov Codecov
Copy link

codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.00%. Comparing base (9f7ba86) to head (8deac7e).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...em_rviz_plugin/src/mrm_summary_overlay_display.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8929      +/-   ##
==========================================
- Coverage   28.00%   28.00%   -0.01%     
==========================================
  Files        1316     1316              
  Lines       98601    98607       +6     
  Branches    39771    39774       +3     
==========================================
  Hits        27615    27615              
- Misses      70840    70846       +6     
  Partials      146      146
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 28.00% <ø> (+<0.01%) ⬆️ Carriedforward from 9f7ba86

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ito-san ito-san merged commit 81e7aba into autowarefoundation:main Sep 24, 2024
31 checks passed
@TetsuKawa
Copy link
Contributor Author

@kminoda
This is the discussion surrounding this PR.
system_error_monitor will be replaced by diagnostic_graph_aggregator.
It was originally planned to be replaced in June, but it was delayed.

rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 24, 2024
@TetsuKawa @rej55
feat(system_error_monitor): remove system error monitor (autowarefoun…
1f966da 
…dation#8929)

* feat: delete-system-error-monitor-from-autoware

Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>

* feat: remove unnecessary params

---------

Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
@rej55 rej55 mentioned this pull request Sep 24, 2024
Merged
rej55 added a commit to tier4/autoware.universe that referenced this pull request Sep 24, 2024
@rej55
Merge pull request #1551 from tier4/feat/delete-system-error-monitor
554ce6d 
feat(system_error_monitor): remove system error monitor (autowarefoundation#8929)
prakash-kannaiah pushed a commit to prakash-kannaiah/autoware.universe that referenced this pull request Oct 9, 2024
@TetsuKawa @prakash-kannaiah
feat(system_error_monitor): remove system error monitor (autowarefoun…
2af09c3 
…dation#8929)

* feat: delete-system-error-monitor-from-autoware

Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>

* feat: remove unnecessary params

---------

Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Signed-off-by: prakash-kannaiah <prakashkanan.pk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ito-san ito-san ito-san approved these changes

@kminoda kminoda kminoda approved these changes

Assignees

@TetsuKawa TetsuKawa

Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned) type:improvement Proposed enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TetsuKawa @kminoda @ito-san