Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(autoware_lidar_centerpoint): use std::size_t instead of size_t #8820

Merged

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Sep 10, 2024

Description

Use std::size_t instead of size_t

Related links

How was this PR tested?

Build works

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Sep 10, 2024
Copy link

github-actions bot commented Sep 10, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kminoda kminoda marked this pull request as ready for review September 10, 2024 05:35
@kminoda kminoda requested a review from knzo25 as a code owner September 10, 2024 05:35
@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 10, 2024
Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.23%. Comparing base (dabeaa6) to head (6c95bf6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8820      +/-   ##
==========================================
- Coverage   25.23%   25.23%   -0.01%     
==========================================
  Files        1325     1325              
  Lines       98805    98816      +11     
  Branches    39670    39673       +3     
==========================================
+ Hits        24932    24933       +1     
- Misses      71276    71286      +10     
  Partials     2597     2597              
Flag Coverage Δ *Carryforward flag
differential 3.74% <ø> (?)
total 25.23% <ø> (ø) Carriedforward from dabeaa6

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda kminoda merged commit d02c012 into autowarefoundation:main Sep 10, 2024
31 of 32 checks passed
@kminoda kminoda deleted the refactor/centerpoint/use_std_size_t branch September 10, 2024 05:54
emuemuJP pushed a commit to arayabrain/autoware.universe.origin that referenced this pull request Sep 10, 2024
…_t (autowarefoundation#8820)

* refactor(autoware_lidar_centerpoint): use std::size_t instead of size_t

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: emuemuJP <k.matsumoto.0807@gmail.com>
knzo25 pushed a commit to tier4/autoware.universe that referenced this pull request Dec 16, 2024
…_t (autowarefoundation#8820)

* refactor(autoware_lidar_centerpoint): use std::size_t instead of size_t

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants