perf(motion_velocity_smoother): remove some heavy debug logging #8798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
maxime-clem
changed the title
maxime-clem
added
the
run:build-and-test-differential
maxime-clem
requested review from
rej55,
go-sakayori,
mkuri,
satoshi-ota and
TakaHoribe
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8798 +/- ##
==========================================
+ Coverage 25.02% 25.41% +0.39%
==========================================
Files 1322 1329 +7
Lines 98047 98374 +327
Branches 37795 37821 +26
==========================================
+ Hits 24536 25003 +467
- Misses 71020 71356 +336
+ Partials 2491 2015 -476
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
force-pushed
the
perf/velocity_smoother
branch
from
99ffcf4 to
78d6669
Compare
maxime-clem
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some debug logging of the
analytical_jerk_constrained_smoothercan take a lot of time (I observed up to 20ms when running locally), even when debug logging is disabled.I have not found a nice solution so this PR simply removes the logging code.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.