Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_behavior_path_goal_planner_module): fix unusedFunction #8786

Merged

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on cppcheck unusedFunction warnings.

planning/behavior_path_planner/autoware_behavior_path_goal_planner_module/src/util.cpp:262:0: style: The function 'extractObjectsInExpandedPullOverLanes' is never used. [unusedFunction]
PredictedObjects extractObjectsInExpandedPullOverLanes(
^

planning/behavior_path_planner/autoware_behavior_path_goal_planner_module/src/util.cpp:81:0: style: The function 'generateExpandedPullOverLanes' is never used. [unusedFunction]
lanelet::ConstLanelets generateExpandedPullOverLanes(
^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 6, 2024
@kobayu858 kobayu858 requested a review from veqcc September 6, 2024 05:02
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.92%. Comparing base (301e36b) to head (f2cdcdb).
Report is 92 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8786      +/-   ##
==========================================
- Coverage   25.02%   24.92%   -0.11%     
==========================================
  Files        1322     1329       +7     
  Lines       98047    98458     +411     
  Branches    37795    37884      +89     
==========================================
  Hits        24536    24536              
- Misses      71020    71431     +411     
  Partials     2491     2491              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 25.02% <ø> (+<0.01%) ⬆️ Carriedforward from 301e36b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kobayu858
Copy link
Contributor Author

@danielsanchezaran @kosuke55 @kyoichi-sugahara @soblin @satoshi-ota @shmpwk @TomohitoAndo @tkimura4
Please confirm the PR. Thank you very much.

@soblin soblin merged commit 07a850d into autowarefoundation:main Sep 13, 2024
41 of 42 checks passed
@kobayu858 kobayu858 deleted the fix/cppcheck_unusedFunction_pla-c1 branch October 1, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants