feat(raw_vehicle_cmd_converter): add vehicle adaptor #8782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
kosuke55
force-pushed
the
feat/vehicle_adaptor_in_raw
branch
from
61e0b78 to
a71f089
Compare
github-actions
bot
removed
the
component:planning
kosuke55
force-pushed
the
feat/vehicle_adaptor_in_raw
branch
2 times, most recently
from
044667d to
afe1b58
Compare
kosuke55
force-pushed
the
feat/vehicle_adaptor_in_raw
branch
from
afe1b58 to
6196bf2
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. |
kosuke55
requested review from
kyoichi-sugahara,
mkuri,
zusizusi,
taikitanaka3,
TakaHoribe,
takayuki5168 and
maxime-clem
as code owners
kosuke55
force-pushed
the
feat/vehicle_adaptor_in_raw
branch
from
6196bf2 to
6591c55
Compare
kosuke55
force-pushed
the
feat/vehicle_adaptor_in_raw
branch
from
6591c55 to
2d2a581
Compare
kosuke55
force-pushed
the
feat/vehicle_adaptor_in_raw
branch
3 times, most recently
from
b745ae6 to
fef4523
Compare
takayuki5168
approved these changes
Dec 20, 2024
github-actions
bot
added
type:documentation
kosuke55
force-pushed
the
feat/vehicle_adaptor_in_raw
branch
4 times, most recently
from
7fe1a73 to
c97147c
Compare
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> sub operation status Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
force-pushed
the
feat/vehicle_adaptor_in_raw
branch
from
c97147c to
1b3b6c0
Compare
xmfcx
reviewed
Dec 22, 2024
| @@ -30,7 +34,7 @@ if(BUILD_TESTING) | |||
| ) | |||
| set(TEST_RAW_VEHICLE_CMD_CONVERTER_EXE test_autoware_raw_vehicle_cmd_converter) | |||
| ament_add_ros_isolated_gtest(${TEST_RAW_VEHICLE_CMD_CONVERTER_EXE} ${TEST_SOURCES}) | |||
| target_link_libraries(${TEST_RAW_VEHICLE_CMD_CONVERTER_EXE} actuation_map_converter autoware_raw_vehicle_cmd_converter_node_component) | |||
| target_link_libraries(${TEST_RAW_VEHICLE_CMD_CONVERTER_EXE} actuation_map_converter vehicle_adaptor autoware_raw_vehicle_cmd_converter_node_component) | |||
There was a problem hiding this comment.
@kosuke55 why did you merge this without running the required checks?
Because this line is too long, the test is failing.
We should never merge without passing the required checks.
|
I'm now checking how it was possible to merge this in the first place.
This bypass list only has @mitsudome-r in it and no one else should be able to merge without passing the status checks. Maybe something is wrong with the required checks maybe? Right now it is like this:
@kosuke55 do you remember if you had to press this button before merging this PR?
|
|
@xmfcx |
|
I am not sure the reason why I could mere but sent PR to fix too long line |
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Dec 25, 2024
…ion#8782) * feat(raw_vehicle_cmd_converter): add vehicle adaptor Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> sub operation status Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * feat(raw_vehicle_cmd_converter): publish vehicle adaptor output Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * use control horizon Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * revert carla Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update docs Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add empty vehicle adaptor which compensates control commands by taking into account vehicle-specific dynamic characteristics.
this feature is set
falseby defaultwe will add an algorithm of vehicle adaptor
Related links
Parent Issue:
How was this PR tested?
check if ACTUATION_CMD sim works with
faseandtrue.false
true
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.