Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal_planner): execute goal planner if previous module path terminal is pull over neighboring lane #8715

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Sep 2, 2024

Description

change pull over request statasu

  • before: The ego vehilc is in the same lane sequence as the goal.
  • after: The terminal of the current path is in the same lane sequence as the goal. (while LC)
lc_goal_planner-2024-09-02_20.38.42.mp4

Related links

Parent Issue:

  • Link

How was this PR tested?

psim
https://evaluation.tier4.jp/evaluation/reports/e3ddffe2-dc9f-5770-8db8-d39caed6741f?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 2, 2024
Copy link

github-actions bot commented Sep 2, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 marked this pull request as ready for review September 2, 2024 12:31
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 4, 2024
@kosuke55 kosuke55 changed the title Feat/lc pull over feat(goal_planner): execute goal planner if previous module path terminal is pull over neighboring lane Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 25.20%. Comparing base (67265bb) to head (07b2bd5).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8715      +/-   ##
==========================================
- Coverage   25.23%   25.20%   -0.04%     
==========================================
  Files        1325     1330       +5     
  Lines       98572    98669      +97     
  Branches    38088    38082       -6     
==========================================
- Hits        24874    24867       -7     
- Misses      71156    71262     +106     
+ Partials     2542     2540       -2     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 25.23% <ø> (+<0.01%) ⬆️ Carriedforward from 67265bb

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 force-pushed the feat/lc_pull_over branch 4 times, most recently from 494fe0b to aed5bd6 Compare September 5, 2024 10:08
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Sep 5, 2024
@kosuke55 kosuke55 force-pushed the feat/lc_pull_over branch 3 times, most recently from c70cbb6 to d718795 Compare September 5, 2024 10:11
@kosuke55 kosuke55 force-pushed the feat/lc_pull_over branch 2 times, most recently from 6ffc726 to d5dccc1 Compare September 5, 2024 10:30
…inal is pull over neighboring lane

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 merged commit 40d87c2 into autowarefoundation:main Sep 9, 2024
29 of 32 checks passed
@kosuke55 kosuke55 deleted the feat/lc_pull_over branch September 9, 2024 18:19
emuemuJP pushed a commit to arayabrain/autoware.universe.origin that referenced this pull request Sep 10, 2024
…inal is pull over neighboring lane (autowarefoundation#8715)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: emuemuJP <k.matsumoto.0807@gmail.com>
AkariNakano821 pushed a commit to AkariNakano821/autoware.universe that referenced this pull request Nov 14, 2024
…inal is pull over neighboring lane (autowarefoundation#8715)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 21, 2024
…inal is pull over neighboring lane (autowarefoundation#8715)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
TetsuKawa pushed a commit to tier4/autoware.universe that referenced this pull request Dec 1, 2024
…inal is pull over neighboring lane (autowarefoundation#8715)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
TetsuKawa added a commit to tier4/autoware.universe that referenced this pull request Dec 6, 2024
…ath terminal is pull over neighboring lane (autowarefoundation#8715)"

This reverts commit 11cb352.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants