Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(autoware_universe_utils): refactor Boost.Geometry alternatives #8594

Conversation

mitukou1109
Copy link
Contributor

@mitukou1109 mitukou1109 commented Aug 23, 2024

Description

This PR moves the implementation of Boost.Geometry alternatives to separate files.

Related links

How was this PR tested?

colcon test --packages-select autoware_universe_utils

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Aug 23, 2024
Copy link

github-actions bot commented Aug 23, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

mitukou1109 and others added 2 commits September 3, 2024 12:04
Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
@mitukou1109 mitukou1109 force-pushed the refactor/boost_geometry_alternatives branch from 188c165 to 61556ae Compare September 3, 2024 03:04
@mitukou1109 mitukou1109 marked this pull request as ready for review September 3, 2024 03:05
@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 3, 2024
Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
@satoshi-ota satoshi-ota enabled auto-merge (squash) September 3, 2024 05:41
@satoshi-ota satoshi-ota merged commit 55cb0cc into autowarefoundation:main Sep 3, 2024
24 of 25 checks passed
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 87.79070% with 21 lines in your changes missing coverage. Please review.

Project coverage is 25.04%. Comparing base (1c2b07b) to head (fbf4127).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...oware_universe_utils/src/geometry/alt_geometry.cpp 90.96% 7 Missing and 7 partials ⚠️
.../autoware/universe_utils/geometry/alt_geometry.hpp 58.82% 3 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8594      +/-   ##
==========================================
+ Coverage   25.02%   25.04%   +0.02%     
==========================================
  Files        1316     1318       +2     
  Lines       97968    97968              
  Branches    37793    37793              
==========================================
+ Hits        24512    24532      +20     
+ Misses      70957    70936      -21     
- Partials     2499     2500       +1     
Flag Coverage Δ *Carryforward flag
differential 26.13% <87.79%> (?)
total 24.91% <ø> (-0.12%) ⬇️ Carriedforward from 1c2b07b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitukou1109 mitukou1109 deleted the refactor/boost_geometry_alternatives branch September 13, 2024 04:34
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
…es (autowarefoundation#8594)

* move alternatives to separate files

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* style(pre-commit): autofix

* include missing headers

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

---------

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants