Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pose_instability_detector)!: prefix package and namespace with autoware #8568

Conversation

a-maumau
Copy link
Contributor

Description

This PR will add the autoware_ prefix to pose_instability_detector.

Related links

Parent Issue:

How was this PR tested?

Checked with running the autoware sample-map.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Aug 22, 2024
Copy link

github-actions bot commented Aug 22, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 22, 2024
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rosdep install occurs an error.

+ rosdep install -y --from-paths src --ignore-src --rosdistro humble
ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
tier4_localization_launch: Cannot locate rosdep definition for [pose_instability_detector]

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.10%. Comparing base (d75f875) to head (4276c27).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8568      +/-   ##
==========================================
+ Coverage   24.01%   24.10%   +0.09%     
==========================================
  Files        1384     1385       +1     
  Lines      102187   102358     +171     
  Branches    38937    39026      +89     
==========================================
+ Hits        24539    24673     +134     
- Misses      75105    75114       +9     
- Partials     2543     2571      +28     
Flag Coverage Δ *Carryforward flag
differential 14.81% <100.00%> (?)
total 24.00% <ø> (-0.02%) ⬇️ Carriedforward from 0c9d517

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@a-maumau
Copy link
Contributor Author

@SakodaShintaro Sorry for my careless mistake, I fixed it at 0c9d517 .

@SakodaShintaro
Copy link
Contributor

There is also a new conflict. 😢
(Why are there so many conflicts?)

@a-maumau
Copy link
Contributor Author

I resolved the conflict at 4276c27 .

(I think the conflict is coming from my own PRs that is changing the order of packages...)

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that logging_simulator works well.

  • Directory Name

    • Add autoware_ as a prefix to the directory name.
  • packages.xml

    • Add autoware_ to the name element.
  • CMakeLists.txt

    • Change the project name to autoware_***.
    • Add autoware:: to PLUGIN.
  • Header Files (.hpp)

    • Start #ifndef guards with AUTOWARE__.
    • Add autoware:: to namespace.
  • Source Files (.cpp)

    • Add autoware:: inside RCLCPP_COMPONENTS_REGISTER_NODE.
  • Launch Files

    • Add autoware_ before find-pkg-share.
    • Change node pkg="<pkgname>" to autoware_<pkgname>.
  • Include

    • Add autoware folder as necessary and update include statements accordingly.
    • Check for impacts on other packages.
  • Verification Points

    • Search find-pkg-share in autoware
    • Check README file (especially json schema)
    • Pay attention to complex cases like sensor_launch as seen in gnss_poser

@SakodaShintaro SakodaShintaro merged commit f58bac6 into autowarefoundation:main Aug 23, 2024
31 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
…th autoware (autowarefoundation#8568)

* add autoware_ prefix

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* add autoware_ prefix

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
a-maumau added a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
…th autoware (autowarefoundation#8568)

* add autoware_ prefix

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* add autoware_ prefix

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
…th autoware (autowarefoundation#8568)

* add autoware_ prefix

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* add autoware_ prefix

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants