Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(perception_utils): add unit test #8414

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Aug 8, 2024

Description

  • Add unit test to make sure the output image after apply run_lenth_encoder and run_length_decoder is the same with the input image

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Aug 8, 2024
Copy link

github-actions bot commented Aug 8, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@badai-nguyen badai-nguyen added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 8, 2024
@badai-nguyen badai-nguyen requested a review from YoshiRi August 8, 2024 13:22
@badai-nguyen badai-nguyen force-pushed the chore/tensorrt_yolox/add_test branch from e455a04 to d4fd047 Compare August 9, 2024 07:59
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.49%. Comparing base (73a9788) to head (0109ac7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8414      +/-   ##
==========================================
+ Coverage   28.47%   28.49%   +0.02%     
==========================================
  Files        1314     1314              
  Lines       98279    98290      +11     
  Branches    39985    39988       +3     
==========================================
+ Hits        27985    28008      +23     
+ Misses      70207    70195      -12     
  Partials       87       87              
Flag Coverage Δ *Carryforward flag
differential 4.57% <ø> (?)
total 28.47% <ø> (ø) Carriedforward from 73a9788

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badai-nguyen badai-nguyen force-pushed the chore/tensorrt_yolox/add_test branch from d4fd047 to 93783b8 Compare August 9, 2024 12:50
@badai-nguyen badai-nguyen force-pushed the chore/tensorrt_yolox/add_test branch from 93783b8 to c193779 Compare August 15, 2024 08:25
@github-actions github-actions bot removed the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Aug 15, 2024
@badai-nguyen badai-nguyen changed the title chore(tensorrt_yolox): add unit test chore(perception_utils): add unit test Aug 15, 2024
@badai-nguyen badai-nguyen marked this pull request as ready for review August 15, 2024 08:56
@badai-nguyen badai-nguyen requested a review from miursh as a code owner August 15, 2024 08:56
@badai-nguyen badai-nguyen force-pushed the chore/tensorrt_yolox/add_test branch from c193779 to 42a0491 Compare August 19, 2024 02:06
@badai-nguyen
Copy link
Contributor Author

@YoshiRi Could also review this PR?

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen badai-nguyen force-pushed the chore/tensorrt_yolox/add_test branch from 42a0491 to e890c53 Compare September 25, 2024 04:43
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Sep 25, 2024
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen force-pushed the chore/tensorrt_yolox/add_test branch from e890c53 to 0109ac7 Compare September 26, 2024 00:04
@github-actions github-actions bot removed the component:common Common packages from the autoware-common repository. (auto-assigned) label Sep 26, 2024
@badai-nguyen badai-nguyen merged commit 9ea73bb into autowarefoundation:main Sep 26, 2024
32 checks passed
prakash-kannaiah pushed a commit to prakash-kannaiah/autoware.universe that referenced this pull request Oct 9, 2024
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: prakash-kannaiah <prakashkanan.pk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants