fix(autoware_multi_object_tracker): revert latency reduction logic and bring back to timer trigger #8277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
github-actions
bot
added
the
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
technolojin
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8277 +/- ##
===========================================
+ Coverage 15.09% 29.20% +14.11%
===========================================
Files 1967 1600 -367
Lines 135941 117487 -18454
Branches 42122 50652 +8530
===========================================
+ Hits 20520 34313 +13793
+ Misses 92700 73991 -18709
+ Partials 22721 9183 -13538
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
zusizusi
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 31, 2024
…d bring back to timer trigger autowarefoundation#8277 (#1436) * fix: revert latency reduction logic and bring back to timer trigger Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * style(pre-commit): autofix * chore: remove unused variables Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
yukkysaito
approved these changes
Aug 5, 2024
technolojin
deleted the
fix/multi-object-tracker-revert-latency-reduction
branch
esteve
pushed a commit
to esteve/autoware.universe
that referenced
this pull request
Aug 13, 2024
…d bring back to timer trigger (autowarefoundation#8277) * fix: revert latency reduction logic and bring back to timer trigger Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * style(pre-commit): autofix * chore: remove unused variables Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert logic of latency reduction.
If CPU usage is high, the process could not be triggered in time. As result, the output is less than incoming messages.
The main process and message publish is back to periodic timer trigger.
Related links
revert of #6710
How was this PR tested?
TIER IV INTERNAL
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.