Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lidar_apollo_segmentation_tvm)!: remove packages #8150

Closed
wants to merge 1 commit into from
Closed

feat(lidar_apollo_segmentation_tvm)!: remove packages #8150

wants to merge 1 commit into from

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jul 23, 2024 •
edited
Loading

Description

Remove this package

https://github.com/orgs/autowarefoundation/discussions/4883#discussioncomment-9876908

Related links

How was this PR tested?

N/A

Notes for reviewers

N/A

Interface changes

N/A

Effects on system behavior

None.

@kminoda
feat!: remove lidar_apollo_segmentation_tvm
51a69dc 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Jul 23, 2024
@github-actions GitHub Actions
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kminoda
Copy link
Contributor Author

kminoda commented Jul 23, 2024

@ambroise-arm @YoshiRi Hi, I would like to remove this package if there is no one using this package, in order to reduce the maintenance cost.
Of course I am open to leaving this package as it is if there is any objections. Thanks!

@kminoda kminoda mentioned this pull request Jul 23, 2024
Merged
4 tasks
@kminoda kminoda marked this pull request as ready for review July 23, 2024 02:10
@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 23, 2024
@kminoda kminoda mentioned this pull request Jul 23, 2024
Merged
@kminoda kminoda changed the title feat!: remove lidar_apollo_segmentation_tvm feat(lidar_apollo_segmentation_tvm)!: remove packages Jul 23, 2024
@kminoda
Copy link
Contributor Author

kminoda commented Jul 23, 2024

@mitsudome-r @xmfcx Hi, let me ping you as I am not sure if there is no one who are using this package out there.

@kminoda
Copy link
Contributor Author

kminoda commented Jul 24, 2024

Transition to
#7996

@kminoda kminoda closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambroise-arm ambroise-arm Awaiting requested review from ambroise-arm

@YoshiRi YoshiRi Awaiting requested review from YoshiRi

Assignees
No one assigned
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kminoda