Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(detected_object_validation): fix shadowVariable #7935

Merged

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on cppcheck shadowVariable warnings

perception/detected_object_validation/src/occupancy_grid_map/occupancy_grid_map_validator.cpp:166:14: style: Local variable 'mask' shadows outer variable [shadowVariable]
        auto mask = getMask(ros_occ_grid, object, passed_objects_image);
             ^

perception/detected_object_validation/src/occupancy_grid_map/occupancy_grid_map_validator.cpp:169:14: style: Local variable 'mask' shadows outer variable [shadowVariable]
        auto mask = getMask(ros_occ_grid, object, removed_objects_image);
             ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 requested a review from veqcc July 10, 2024 07:41
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jul 10, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 28.76%. Comparing base (050fa29) to head (4d849b5).
Report is 17 commits behind head on main.

Files Patch % Lines
...ccupancy_grid_map/occupancy_grid_map_validator.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7935      +/-   ##
==========================================
+ Coverage   28.74%   28.76%   +0.02%     
==========================================
  Files        1593     1594       +1     
  Lines      116848   116852       +4     
  Branches    50027    50050      +23     
==========================================
+ Hits        33586    33615      +29     
+ Misses      74221    74139      -82     
- Partials     9041     9098      +57     
Flag Coverage Δ *Carryforward flag
differential 2.87% <0.00%> (?)
total 28.77% <ø> (+0.02%) ⬆️ Carriedforward from a39cfb7

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kobayu858
Copy link
Contributor Author

@badai-nguyen @Shin-kyoto @miursh @YoshiRi @yukkysaito

Please confirm the PR. Thank you very much.

@kobayu858 kobayu858 merged commit edb7cb4 into autowarefoundation:main Jul 19, 2024
39 checks passed
yhisaki pushed a commit to yhisaki/autoware.universe that referenced this pull request Jul 19, 2024
…on#7935)

fix:shadowVariable

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
…on#7935)

fix:shadowVariable

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
chihungtzeng pushed a commit to chihungtzeng/autoware.universe that referenced this pull request Jul 23, 2024
…on#7935)

fix:shadowVariable

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 deleted the fix/cppcheck_shadowVariable_per-2 branch July 23, 2024 01:13
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
…on#7935)

fix:shadowVariable

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants