fix(perception_online_evaluator): fix shadowVariable #7933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
kobayu858
requested review from
rej55,
kosuke55,
ktro2828,
kyoichi-sugahara,
miursh and
YoshiRi
as code owners
github-actions
bot
added
the
component:evaluator
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
veqcc
reviewed
Jul 10, 2024
evaluator/perception_online_evaluator/src/perception_online_evaluator_node.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
veqcc
approved these changes
Jul 10, 2024
kobayu858
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7933 +/- ##
===========================================
+ Coverage 15.09% 28.44% +13.34%
===========================================
Files 1967 1594 -373
Lines 135941 116242 -19699
Branches 42122 49618 +7496
===========================================
+ Hits 20520 33063 +12543
+ Misses 92700 74157 -18543
+ Partials 22721 9022 -13699
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
miursh
approved these changes
Jul 19, 2024
yhisaki
pushed a commit
to yhisaki/autoware.universe
that referenced
this pull request
Jul 19, 2024
…ion#7933) * fix:shadowVariable Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> * fix:clang-format Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> * fix:shadowVariable Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> --------- Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Ariiees
pushed a commit
to Ariiees/autoware.universe
that referenced
this pull request
Jul 22, 2024
…ion#7933) * fix:shadowVariable Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> * fix:clang-format Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> * fix:shadowVariable Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> --------- Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
chihungtzeng
pushed a commit
to chihungtzeng/autoware.universe
that referenced
this pull request
Jul 23, 2024
…ion#7933) * fix:shadowVariable Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> * fix:clang-format Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> * fix:shadowVariable Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> --------- Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
esteve
pushed a commit
to esteve/autoware.universe
that referenced
this pull request
Aug 13, 2024
…ion#7933) * fix:shadowVariable Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> * fix:clang-format Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> * fix:shadowVariable Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> --------- Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix based on cppcheck shadowVariable warnings
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.