Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tensorrt_yolox): add run length encoding for sematic segmentation mask #7905

Merge branch 'main' into fix/add_run_length_compressed

4ced050
Select commit
Loading
Failed to load commit list.
Merged

fix(tensorrt_yolox): add run length encoding for sematic segmentation mask #7905

Merge branch 'main' into fix/add_run_length_compressed
4ced050
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Aug 8, 2024 in 45s

CodeScene PR Check

Code Health Quality Gates: FAILED

Change in average Code Health of affected files: +0.28 (7.49 -> 7.78)

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method tensorrt_yolox_node.cpp: TrtYoloXNode::onImage
  • Bumpy Road Ahead tensorrt_yolox_node.cpp: TrtYoloXNode::onImage

Annotations

Check warning on line 193 in perception/autoware_tensorrt_yolox/src/tensorrt_yolox_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

TrtYoloXNode::onImage increases in cyclomatic complexity from 10 to 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 193 in perception/autoware_tensorrt_yolox/src/tensorrt_yolox_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

TrtYoloXNode::onImage has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check notice on line 1 in perception/autoware_tensorrt_yolox/src/tensorrt_yolox_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Overall Code Complexity

The mean cyclomatic complexity increases from 5.43 to 5.57, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.