Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(autoware_object_merger): move headers to src and rename package #7804

Merged
merged 2 commits into from
Jul 19, 2024
Merged

refactor(autoware_object_merger): move headers to src and rename package #7804

merged 2 commits into from
Jul 19, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Jul 3, 2024

Description

Move headers to src and rename package

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jul 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@esteve esteve force-pushed the fix-include-dir-autoware_object_merger branch from a8d166f to b28c98d Compare July 3, 2024 09:25
@esteve esteve changed the title move headers to src and rename package refactor(autoware_object_merger): move headers to src and rename package Jul 3, 2024
@esteve
Copy link
Contributor Author

esteve commented Jul 3, 2024

@technolojin I've submitted this PR as a follow-up to #7642 to update the package name and move the headers, let me know if the changes are ok. Thanks.

@esteve esteve enabled auto-merge (squash) July 3, 2024 10:53
technolojin
technolojin requested changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@technolojin technolojin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@technolojin I've submitted this PR as a follow-up to #7642 to update the package name and move the headers, let me know if the changes are ok. Thanks.

Thank you for your work.

  1. package renaming
    I forgot to explain my strategy that the package names in /perception will be changed later in a concentrated time to minimize impact of other linked repositories and systems rely on.
    However, this package name seems to be fine to be changed (considering the package name is used within autoware_universe).

  2. moving headers
    I am considering the association to be shared in the future. this association part is the same as multi_object_tracker, radar_object_tracker, and tracking_object_merger.
    Let me do the re-organization later.

This was referenced Jul 4, 2024
Merged
Closed
@esteve esteve mentioned this pull request Jul 4, 2024
Open
@esteve esteve force-pushed the fix-include-dir-autoware_object_merger branch from 0333cdf to 4aa2a5f Compare July 16, 2024 12:16
@esteve esteve marked this pull request as draft July 16, 2024 12:17
auto-merge was automatically disabled July 16, 2024 12:17

Pull request was converted to draft

@esteve esteve added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 16, 2024
@esteve
refactor(autoware_object_merger): move headers to src and rename package
948b30f 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve esteve force-pushed the fix-include-dir-autoware_object_merger branch from 7fdac87 to 948b30f Compare July 16, 2024 12:39
@esteve esteve marked this pull request as ready for review July 16, 2024 12:39
@esteve esteve enabled auto-merge (squash) July 16, 2024 12:39
@esteve
Copy link
Contributor Author

esteve commented Jul 16, 2024

@technolojin I've moved the header files to a public directory, can you have a look at the changes when you have a moment? Thanks.

@codecov Codecov
Copy link

codecov bot commented Jul 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.91%. Comparing base (106625a) to head (948b30f).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7804      +/-   ##
==========================================
- Coverage   28.95%   28.91%   -0.05%     
==========================================
  Files        1606     1611       +5     
  Lines      117598   117765     +167     
  Branches    50597    50630      +33     
==========================================
  Hits        34046    34046              
- Misses      74299    74466     +167     
  Partials     9253     9253
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 28.95% <ø> (+<0.01%) ⬆️ Carriedforward from 42e466a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin technolojin self-assigned this Jul 17, 2024
@esteve
Copy link
Contributor Author

esteve commented Jul 17, 2024

@yukkysaito @YoshiRi @miursh can you have a look at this PR? Thanks.

@yukkysaito
Copy link
Contributor

yukkysaito commented Jul 18, 2024 •
edited
Loading

@esteve Thank you for the reminder.
@technolojin Could you please review this?

technolojin
technolojin requested changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the launcher?
$(find-pkg-share object_merger) -> $(find-pkg-share autoware_object_merger)

perception/autoware_object_merger/launch/object_association_merger.launch.xml Outdated Show resolved Hide resolved
@technolojin
refactor(autoware_object_merger): update package paths in launch files
cb97667 
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
technolojin
technolojin approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the launchers.

@esteve esteve merged commit 108e65a into autowarefoundation:main Jul 19, 2024
22 of 23 checks passed
@esteve esteve deleted the fix-include-dir-autoware_object_merger branch July 19, 2024 01:00
yhisaki pushed a commit to yhisaki/autoware.universe that referenced this pull request Jul 19, 2024
@esteve @yhisaki
refactor(autoware_object_merger): move headers to src and rename pack…
1144cef 
…age (autowarefoundation#7804)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
@esteve @Ariiees
refactor(autoware_object_merger): move headers to src and rename pack…
f62c01b 
…age (autowarefoundation#7804)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
chihungtzeng pushed a commit to chihungtzeng/autoware.universe that referenced this pull request Jul 23, 2024
@esteve
refactor(autoware_object_merger): move headers to src and rename pack…
8bf6936 
…age (autowarefoundation#7804)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: chtseng <chtseng@itri.org.tw>
esteve added a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
@esteve
refactor(autoware_object_merger): move headers to src and rename pack…
8d1d7ee 
…age (autowarefoundation#7804)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@technolojin technolojin technolojin approved these changes

@YoshiRi YoshiRi Awaiting requested review from YoshiRi YoshiRi is a code owner

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito is a code owner

@miursh miursh Awaiting requested review from miursh miursh is a code owner

Assignees

@technolojin technolojin

Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esteve @yukkysaito @technolojin