Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(livox_tag_filter): prefix package and namespace with autoware #7788

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Jul 2, 2024

Description

prefix package and namespace with autoware

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) labels Jul 2, 2024
Copy link

github-actions bot commented Jul 2, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.36%. Comparing base (ce09907) to head (a3edc4f).

Files Patch % Lines
...are_livox_tag_filter/src/livox_tag_filter_node.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7788      +/-   ##
==========================================
- Coverage   28.37%   28.36%   -0.01%     
==========================================
  Files        1584     1585       +1     
  Lines      115596   115613      +17     
  Branches    49279    49283       +4     
==========================================
  Hits        32799    32799              
- Misses      73849    73866      +17     
  Partials     8948     8948              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 28.37% <ø> (ø) Carriedforward from ce09907

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve esteve force-pushed the prefix-livox_tag_filter branch from c5b130f to a3edc4f Compare July 2, 2024 11:03
@esteve esteve marked this pull request as ready for review July 2, 2024 12:21
@esteve esteve requested review from knzo25 and mitsudome-r as code owners July 2, 2024 12:21
@esteve esteve enabled auto-merge (squash) July 2, 2024 12:21
Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@esteve esteve merged commit 50fe5d0 into autowarefoundation:main Jul 3, 2024
29 of 30 checks passed
@esteve esteve deleted the prefix-livox_tag_filter branch July 3, 2024 01:20
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
autowarefoundation#7788)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
#7788)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants