Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(kalman_filter): prefix package and namespace with autoware #7787

Merged
merged 2 commits into from
Aug 19, 2024
Merged

refactor(kalman_filter): prefix package and namespace with autoware #7787

merged 2 commits into from
Aug 19, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Jul 2, 2024

Description

prefix package and namespace with autoware

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Jul 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@esteve esteve mentioned this pull request Jul 2, 2024
Open
@esteve esteve added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 2, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.96%. Comparing base (77059a1) to head (3f48cda).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7787      +/-   ##
==========================================
+ Coverage   23.88%   23.96%   +0.07%     
==========================================
  Files        1380     1383       +3     
  Lines      101872   101728     -144     
  Branches    38793    38657     -136     
==========================================
+ Hits        24333    24375      +42     
+ Misses      75067    74854     -213     
- Partials     2472     2499      +27
Flag Coverage Δ *Carryforward flag
differential 9.83% <ø> (?)
total 23.91% <ø> (+0.03%) ⬆️ Carriedforward from 5badea8

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteve esteve force-pushed the prefix-kalman_filter branch from 65a5ce5 to 86f9ba0 Compare July 2, 2024 11:02
@esteve esteve changed the title refactor(kalman_fiilter): prefix package and namespace with autoware refactor(kalman_filter): prefix package and namespace with autoware Jul 2, 2024
@esteve esteve marked this pull request as ready for review July 2, 2024 12:21
@esteve esteve enabled auto-merge (squash) July 2, 2024 12:21
technolojin
technolojin reviewed Jul 3, 2024
View reviewed changes
Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the include directory topic, LGTM

@esteve esteve marked this pull request as draft July 3, 2024 08:37
@esteve
Copy link
Contributor Author

esteve commented Jul 3, 2024

Back to draft to fix the issue in #7787 (comment)

@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jul 3, 2024
@esteve esteve marked this pull request as ready for review July 3, 2024 08:54
@esteve
Copy link
Contributor Author

esteve commented Jul 3, 2024

@SakodaShintaro @technolojin fixed in 8b60723

SakodaShintaro
SakodaShintaro approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that logging_simulator works well.
LGTM(for /localization)

@esteve esteve enabled auto-merge (squash) July 3, 2024 11:06
@esteve esteve force-pushed the prefix-kalman_filter branch from af5102b to ff4a227 Compare July 3, 2024 11:23
technolojin
technolojin approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of Perception, LGTM

@esteve esteve force-pushed the prefix-kalman_filter branch 2 times, most recently from 75cd59d to e1c7195 Compare July 16, 2024 13:02
@Motsu-san
Copy link
Contributor

@manato @YoshiRi Could you review this pull-request?

YoshiRi
YoshiRi approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logging simulator worked in my local environment. LGTM.

@Motsu-san
Copy link
Contributor

@esteve Could you resolve the conflicts?

@esteve esteve force-pushed the prefix-kalman_filter branch from e1c7195 to 3ad65c1 Compare August 7, 2024 09:03
@esteve
Copy link
Contributor Author

esteve commented Aug 7, 2024

@Motsu-san fixed

@esteve esteve force-pushed the prefix-kalman_filter branch from 3ad65c1 to 07f8385 Compare August 13, 2024 07:30
@YoshiRi
Copy link
Contributor

YoshiRi commented Aug 13, 2024

I think we need approve from each components maintainers.

Hi, could you approve this PR? We have already checked this PR.

TakaHoribe
TakaHoribe reviewed Aug 14, 2024
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
@esteve
refactor(kalman_filter): prefix package and namespace with autoware
5badea8 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve esteve force-pushed the prefix-kalman_filter branch from 07f8385 to 5badea8 Compare August 14, 2024 12:30
manato
manato approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@manato manato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding autoware_bytetrack, LGTM. Thank you for your contribution!

@vividf
Copy link
Contributor

vividf commented Aug 16, 2024

@kminoda @yukkysaito
It seems that we need a code owner review for this PR.

@esteve esteve merged commit 2f392a8 into autowarefoundation:main Aug 19, 2024
28 of 30 checks passed
@esteve esteve deleted the prefix-kalman_filter branch August 19, 2024 02:20
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
@esteve @pre-commit-ci @kyoichi-sugahara
refactor(kalman_filter): prefix package and namespace with autoware (a…
89a993f 
…utowarefoundation#7787)

* refactor(kalman_filter): prefix package and namespace with autoware

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* move headers to include/autoware/

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@esteve esteve mentioned this pull request Sep 24, 2024
Open
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@technolojin technolojin technolojin approved these changes

@SakodaShintaro SakodaShintaro SakodaShintaro approved these changes

@TakaHoribe TakaHoribe TakaHoribe approved these changes

@YoshiRi YoshiRi YoshiRi approved these changes

@yukkysaito yukkysaito yukkysaito approved these changes

@manato manato manato approved these changes

@scepter914 scepter914 Awaiting requested review from scepter914

@anhnv3991 anhnv3991 Awaiting requested review from anhnv3991

@KYabuuchi KYabuuchi Awaiting requested review from KYabuuchi

@kminoda kminoda Awaiting requested review from kminoda kminoda is a code owner

@Motsu-san Motsu-san Awaiting requested review from Motsu-san

@RyuYamamoto RyuYamamoto Awaiting requested review from RyuYamamoto

@TaikiYamada4 TaikiYamada4 Awaiting requested review from TaikiYamada4

@IshitaTakeshi IshitaTakeshi Awaiting requested review from IshitaTakeshi IshitaTakeshi is a code owner

@YamatoAndo YamatoAndo Awaiting requested review from YamatoAndo

Assignees

@esteve esteve

Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@esteve @Motsu-san @YoshiRi @vividf @manato @yukkysaito @TakaHoribe @SakodaShintaro @technolojin