Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(control_evaluator): use class naming standard and use remapped param name #7782

Merged

Conversation

danielsanchezaran
Copy link
Contributor

@danielsanchezaran danielsanchezaran commented Jul 2, 2024

Description

Change class name and use the remapped topic name for consistency.

Related links

Parent Issue:

  • Link

How was this PR tested?

PSim

cap-.2024-07-02-15-33-08.mp4

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@github-actions github-actions bot added component:launch Launch files, scripts and initialization tools. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Jul 2, 2024
Copy link

github-actions bot commented Jul 2, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@danielsanchezaran danielsanchezaran added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 2, 2024
@danielsanchezaran danielsanchezaran enabled auto-merge (squash) July 2, 2024 09:21
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 28.36%. Comparing base (9fcad6b) to head (d8c2954).
Report is 4 commits behind head on main.

Files Patch % Lines
...e_control_evaluator/src/control_evaluator_node.cpp 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7782      +/-   ##
==========================================
- Coverage   28.36%   28.36%   -0.01%     
==========================================
  Files        1584     1585       +1     
  Lines      115529   115554      +25     
  Branches    49251    49254       +3     
==========================================
  Hits        32773    32773              
- Misses      73812    73837      +25     
  Partials     8944     8944              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 28.37% <ø> (+<0.01%) ⬆️ Carriedforward from 9fcad6b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielsanchezaran danielsanchezaran merged commit ce09907 into autowarefoundation:main Jul 2, 2024
39 of 41 checks passed
@danielsanchezaran danielsanchezaran deleted the refactor/control-evaluator branch July 2, 2024 09:30
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jul 3, 2024
…ed param name (autowarefoundation#7782)

use class naming standard and use remapped param name

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
…ed param name (autowarefoundation#7782)

use class naming standard and use remapped param name

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
…ed param name (autowarefoundation#7782)

use class naming standard and use remapped param name

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…ed param name (#7782)

use class naming standard and use remapped param name

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Oct 11, 2024
…ed param name (autowarefoundation#7782)

use class naming standard and use remapped param name

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Oct 28, 2024
…ed param name (autowarefoundation#7782)

use class naming standard and use remapped param name

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Nov 14, 2024
…ed param name (autowarefoundation#7782)

use class naming standard and use remapped param name

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants