refactor(tracking_object_merger)!: fix namespace and directory structure #7663

technolojin · 2024-06-24T10:13:03Z

Description

This PR puts headers in the autoware namespace.
Part of: autowarefoundation/autoware#4569

Additional works

Align directory structure to follow the coding guidelines.
Clean unused dependencies LIST

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

codecov · 2024-06-25T05:02:21Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (507e3f4) to head (4509c2f).
Report is 168 commits behind head on main.

Files	Patch %	Lines
...ject_merger/src/decorative_tracker_merger_node.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #7663       +/-   ##
==========================================
- Coverage   14.84%   0.00%   -14.85%     
==========================================
  Files        1999      65     -1934     
  Lines      139163    3699   -135464     
  Branches    43716     322    -43394     
==========================================
- Hits        20661       0    -20661     
+ Misses      95731    3699    -92032     
+ Partials    22771       0    -22771

Flag	Coverage Δ
differential	`0.00% <0.00%> (?)`
total	`?`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-06-25T08:54:32Z

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

You've checked our contribution guidelines.
Your PR follows our pull request guidelines.
All required CI checks pass before marking the PR ready for review.

YoshiRi

LGTM

) * feat: separate filters Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: object validator to modular Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: replace xyzrpy covariance index Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor tracker class members Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactoring destructor Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactoring getUpdatingObject Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactoring object size checker Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: debugger delay calculation order is fixed Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: bicycle size update bug fix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: renamed message package Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactoring Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: object parameter class Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor includes Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: initial impl. of object model Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: impl. object model to bicycle, big, normal Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: impl. object model to pedestrian Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: impl. cont Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: fix missing refactoring Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: align unit of angles, yaw rates Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: rename tier4_autoware_utils to autoware_universe_utils Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: missing unit conversion Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: sources Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: Update include and import statements Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: unit convert bug Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: update to autoware::universe_utils Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: mis-implementation of process noise Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

…ure (autowarefoundation#7663) * chore: refactor file paths in tracking_object_merger module Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor file paths in tracking_object_merger module Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor include statement in decorative_tracker_merger.hpp Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor include statement in decorative_tracker_merger.hpp Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp * chore: refactor association file path in tracking_object_merger module Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: update include statements in tracking_object_merger module Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: move the node header to src Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp

…ure (autowarefoundation#7663) * chore: refactor file paths in tracking_object_merger module Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor file paths in tracking_object_merger module Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor include statement in decorative_tracker_merger.hpp Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor include statement in decorative_tracker_merger.hpp Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp * chore: refactor association file path in tracking_object_merger module Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: update include statements in tracking_object_merger module Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: move the node header to src Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp Signed-off-by: palas21 <palas21@itu.edu.tr>

…ure (autowarefoundation#7663) * chore: refactor file paths in tracking_object_merger module Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor file paths in tracking_object_merger module Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor include statement in decorative_tracker_merger.hpp Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor include statement in decorative_tracker_merger.hpp Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp * chore: refactor association file path in tracking_object_merger module Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: update include statements in tracking_object_merger module Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: move the node header to src Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp

…ure (#7663) * chore: refactor file paths in tracking_object_merger module Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor file paths in tracking_object_merger module Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor include statement in decorative_tracker_merger.hpp Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor include statement in decorative_tracker_merger.hpp Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp * chore: refactor association file path in tracking_object_merger module Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: update include statements in tracking_object_merger module Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: move the node header to src Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp

github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jun 24, 2024

technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 25, 2024

technolojin changed the title ~~refactor(tracking_object_merger): namespace fix~~ refactor(tracking_object_merger)!: fix namespace and directory structure Jun 25, 2024

technolojin marked this pull request as ready for review June 25, 2024 09:32

technolojin requested review from YoshiRi and yukkysaito as code owners June 25, 2024 09:32

esteve mentioned this pull request Jun 25, 2024

Prefix packages with autoware_ prefix and keep code in autoware namespace autowarefoundation/autoware#4569

Open

technolojin assigned technolojin and YoshiRi Jun 26, 2024

technolojin enabled auto-merge (squash) June 27, 2024 06:41

YoshiRi approved these changes Jun 27, 2024

View reviewed changes

technolojin and others added 8 commits June 27, 2024 15:48

chore: refactor file paths in tracking_object_merger module

e497ef7

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

chore: refactor file paths in tracking_object_merger module

ce17b55

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

chore: refactor include statement in decorative_tracker_merger.hpp

6513fce

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

chore: refactor include statement in decorative_tracker_merger.hpp

c685829

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

chore: refactor association file path in tracking_object_merger module

06a3528

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

refactor: update include statements in tracking_object_merger module

834a4a2

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

refactor: move the node header to src

fb9cc44

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

technolojin force-pushed the refactor/namespace-tracking_object_merger branch from 2858871 to fb9cc44 Compare June 27, 2024 06:49

Merge branch 'main' into refactor/namespace-tracking_object_merger

4509c2f

technolojin merged commit cfcf1e7 into autowarefoundation:main Jun 27, 2024
28 of 31 checks passed

technolojin deleted the refactor/namespace-tracking_object_merger branch July 26, 2024 02:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(tracking_object_merger)!: fix namespace and directory structure #7663

refactor(tracking_object_merger)!: fix namespace and directory structure #7663

technolojin commented Jun 24, 2024 •

edited

Loading

codecov bot commented Jun 25, 2024 •

edited

Loading

github-actions bot commented Jun 25, 2024 •

edited

Loading

YoshiRi left a comment

refactor(tracking_object_merger)!: fix namespace and directory structure #7663

refactor(tracking_object_merger)!: fix namespace and directory structure #7663

Conversation

technolojin commented Jun 24, 2024 • edited Loading

Description

Tests performed

Effects on system behavior

Interface changes

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov bot commented Jun 25, 2024 • edited Loading

Codecov Report

github-actions bot commented Jun 25, 2024 • edited Loading

YoshiRi left a comment

Choose a reason for hiding this comment

technolojin commented Jun 24, 2024 •

edited

Loading

codecov bot commented Jun 25, 2024 •

edited

Loading

github-actions bot commented Jun 25, 2024 •

edited

Loading