Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(radar_tracks_msgs_converter)!: fix namespace and directory structure #7653

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Jun 24, 2024

Description

This PR puts headers in the autoware namespace.
Part of: autowarefoundation/autoware#4569

Additional works

  1. Align directory structure to follow the coding guidelines.
  2. Clean unused dependencies list

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jun 24, 2024
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (507e3f4) to head (1b626a5).
Report is 145 commits behind head on main.

Files Patch % Lines
...converter/src/radar_tracks_msgs_converter_node.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7653       +/-   ##
==========================================
- Coverage   14.84%   0.00%   -14.85%     
==========================================
  Files        1999      34     -1965     
  Lines      139163    1916   -137247     
  Branches    43716      78    -43638     
==========================================
- Hits        20661       0    -20661     
+ Misses      95731    1916    -93815     
+ Partials    22771       0    -22771     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin force-pushed the refactor/namespace-radar_tracks_msgs_converter branch from 6574e48 to 3b34340 Compare June 24, 2024 07:47
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin changed the title refactor(radar_tracks_msgs_converter): namespace fix refactor(radar_tracks_msgs_converter)!: fix namespace and directory structure Jun 25, 2024
…de.hpp

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Copy link

github-actions bot commented Jun 25, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin marked this pull request as ready for review June 25, 2024 09:59
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Copy link
Contributor

@scepter914 scepter914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(Note: without checking acting, after integrating with other PRs and checking acting this PR can be merged)

@technolojin technolojin merged commit 8614acc into autowarefoundation:main Jun 27, 2024
33 of 35 checks passed
mitukou1109 pushed a commit to mitukou1109/autoware.universe that referenced this pull request Jul 2, 2024
…tructure (autowarefoundation#7653)

* refactor: radar_tracks_msgs_converter library and node

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename node.hpp to radar_tracks_msgs_converter_node.hpp

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: fix the node name

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: update include statement for radar_tracks_msgs_converter_node.hpp

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: remove unused dependencies

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: move header file to src

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
…tructure (autowarefoundation#7653)

* refactor: radar_tracks_msgs_converter library and node

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename node.hpp to radar_tracks_msgs_converter_node.hpp

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: fix the node name

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: update include statement for radar_tracks_msgs_converter_node.hpp

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: remove unused dependencies

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: move header file to src

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
…tructure (autowarefoundation#7653)

* refactor: radar_tracks_msgs_converter library and node

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename node.hpp to radar_tracks_msgs_converter_node.hpp

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: fix the node name

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: update include statement for radar_tracks_msgs_converter_node.hpp

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: remove unused dependencies

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: move header file to src

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…tructure (#7653)

* refactor: radar_tracks_msgs_converter library and node

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename node.hpp to radar_tracks_msgs_converter_node.hpp

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: fix the node name

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: update include statement for radar_tracks_msgs_converter_node.hpp

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: remove unused dependencies

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: move header file to src

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin deleted the refactor/namespace-radar_tracks_msgs_converter branch July 26, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants