-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(radar_tracks_msgs_converter)!: fix namespace and directory structure #7653
refactor(radar_tracks_msgs_converter)!: fix namespace and directory structure #7653
Conversation
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7653 +/- ##
==========================================
- Coverage 14.84% 0.00% -14.85%
==========================================
Files 1999 34 -1965
Lines 139163 1916 -137247
Branches 43716 78 -43638
==========================================
- Hits 20661 0 -20661
+ Misses 95731 1916 -93815
+ Partials 22771 0 -22771
☔ View full report in Codecov by Sentry. |
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
6574e48
to
3b34340
Compare
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…de.hpp Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(Note: without checking acting, after integrating with other PRs and checking acting this PR can be merged)
…tructure (autowarefoundation#7653) * refactor: radar_tracks_msgs_converter library and node Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: rename node.hpp to radar_tracks_msgs_converter_node.hpp Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: fix the node name Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: update include statement for radar_tracks_msgs_converter_node.hpp Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: remove unused dependencies Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: move header file to src Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…tructure (autowarefoundation#7653) * refactor: radar_tracks_msgs_converter library and node Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: rename node.hpp to radar_tracks_msgs_converter_node.hpp Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: fix the node name Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: update include statement for radar_tracks_msgs_converter_node.hpp Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: remove unused dependencies Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: move header file to src Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Signed-off-by: palas21 <palas21@itu.edu.tr>
…tructure (autowarefoundation#7653) * refactor: radar_tracks_msgs_converter library and node Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: rename node.hpp to radar_tracks_msgs_converter_node.hpp Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: fix the node name Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: update include statement for radar_tracks_msgs_converter_node.hpp Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: remove unused dependencies Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: move header file to src Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…tructure (#7653) * refactor: radar_tracks_msgs_converter library and node Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: rename node.hpp to radar_tracks_msgs_converter_node.hpp Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: fix the node name Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: update include statement for radar_tracks_msgs_converter_node.hpp Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: remove unused dependencies Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: move header file to src Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Description
This PR puts headers in the
autoware
namespace.Part of: autowarefoundation/autoware#4569
Additional works
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.