Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(object_merger)!: fix namespace and directory structure #7642

refactor: update include paths for object association node

e7baa9e
Select commit
Loading
Failed to load commit list.
Merged

refactor(object_merger)!: fix namespace and directory structure #7642

refactor: update include paths for object association node
e7baa9e
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jun 28, 2024 in 54s

CodeScene PR Check

Code Health Quality Gates: FAILED

  • Declining Code Health: 13 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method successive_shortest_path.cpp: SSP::maximizeLinearAssignment
  • Bumpy Road Ahead successive_shortest_path.cpp: SSP::maximizeLinearAssignment
  • Deep, Nested Complexity data_association.cpp: DataAssociation::calcScoreMatrix
  • Deep, Nested Complexity successive_shortest_path.cpp: SSP::maximizeLinearAssignment
  • Deep, Nested Complexity object_association_merger_node.cpp: ObjectAssociationMergerNode::objectsCallback
  • Complex Method object_association_merger_node.cpp: ObjectAssociationMergerNode::objectsCallback
  • Complex Method data_association.cpp: DataAssociation::calcScoreMatrix
  • Complex Conditional successive_shortest_path.cpp: SSP::maximizeLinearAssignment
  • Excess Number of Function Arguments object_association_merger_node.cpp: isUnknownObjectOverlapped
  • Complex Method data_association.cpp: DataAssociation::assign
  • Bumpy Road Ahead data_association.cpp: DataAssociation::calcScoreMatrix
  • Bumpy Road Ahead object_association_merger_node.cpp: ObjectAssociationMergerNode::objectsCallback
  • Bumpy Road Ahead data_association.cpp: DataAssociation::assign

Annotations

Check warning on line 234 in perception/object_merger/src/object_association_merger_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

ObjectAssociationMergerNode::objectsCallback has a cyclomatic complexity of 19, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 234 in perception/object_merger/src/object_association_merger_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

ObjectAssociationMergerNode::objectsCallback has 4 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 234 in perception/object_merger/src/object_association_merger_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

ObjectAssociationMergerNode::objectsCallback has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.

Check warning on line 57 in perception/object_merger/src/object_association_merger_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

isUnknownObjectOverlapped has 6 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

Check warning on line 176 in perception/object_merger/src/association/data_association.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

DataAssociation::calcScoreMatrix has a cyclomatic complexity of 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 115 in perception/object_merger/src/association/data_association.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

DataAssociation::assign has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 176 in perception/object_merger/src/association/data_association.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

DataAssociation::calcScoreMatrix has 4 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 115 in perception/object_merger/src/association/data_association.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

DataAssociation::assign has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 176 in perception/object_merger/src/association/data_association.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

DataAssociation::calcScoreMatrix has a nested complexity depth of 5, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.

Check warning on line 369 in perception/object_merger/src/association/solver/successive_shortest_path.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

SSP::maximizeLinearAssignment has a cyclomatic complexity of 42, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 351 in perception/object_merger/src/association/solver/successive_shortest_path.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional

SSP::maximizeLinearAssignment has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.

Check warning on line 369 in perception/object_merger/src/association/solver/successive_shortest_path.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

SSP::maximizeLinearAssignment has 11 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 369 in perception/object_merger/src/association/solver/successive_shortest_path.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

SSP::maximizeLinearAssignment has a nested complexity depth of 5, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.