fix: missing dependency for Jazzy #7600

f0reachARR · 2024-06-20T05:56:10Z

Description

This PR add / modify dependencies written in package.xml.
The changed dependencies are almost about ament_index_cpp.
For reasons unknown, Jazzy has a build error due to not having a dependency on ament_index_cpp.
We have found similar errors in other ROS packages and have confirmed that they are not specific to the author's environment.

Reference: #7598

Tests performed

colcon test passed.
This PR does not change the behavior of Autoware.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: f0reachARR <f0reach@f0reach.me>

codecov · 2024-06-20T07:02:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.12%. Comparing base (f33635c) to head (0d811fd).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7600      +/-   ##
==========================================
- Coverage   29.13%   28.12%   -1.01%     
==========================================
  Files        1607      886     -721     
  Lines      118180    74340   -43840     
  Branches    50849    28598   -22251     
==========================================
- Hits        34427    20909   -13518     
+ Misses      74534    50385   -24149     
+ Partials     9219     3046    -6173

Flag	Coverage Δ
differential	`28.12% <ø> (?)`
total	`?`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mitsudome-r · 2024-06-20T15:04:09Z

planning/autoware_static_centerline_generator/package.xml

@@ -29,6 +29,7 @@
  <depend>geography_utils</depend>
  <depend>geometry_msgs</depend>
  <depend>global_parameter_loader</depend>
+  <depend>grid_map_ros</depend>


Could you tell me the error output when if don't have grid_map_ros added into this dependency?
I have quickly searched the code with grid_map as a keyword in autoware_static_centerline_generator package, but I couldn't get any search results.

I have some errors without grid_map_ros.

<command-line>: fatal error: grid_map_core/eigen_plugins/FunctorsPlugin.hpp: No such file or directory compilation terminated. gmake[2]: *** [CMakeFiles/main.dir/build.make:132: CMakeFiles/main.dir/src/utils.cpp.o] Error 1 gmake[2]: *** Waiting for unfinished jobs.... <command-line>: fatal error: grid_map_core/eigen_plugins/FunctorsPlugin.hpp: No such file or directory compilation terminated. gmake[2]: *** [CMakeFiles/main.dir/build.make:118: CMakeFiles/main.dir/src/centerline_source/bag_ego_trajectory_based_centerline.cpp.o] Error 1 <command-line>: fatal error: grid_map_core/eigen_plugins/FunctorsPlugin.hpp: No such file or directory compilation terminated. gmake[2]: *** [CMakeFiles/main.dir/build.make:104: CMakeFiles/main.dir/src/centerline_source/optimization_trajectory_based_centerline.cpp.o] Error 1 <command-line>: fatal error: grid_map_core/eigen_plugins/FunctorsPlugin.hpp: No such file or directory compilation terminated. gmake[2]: *** [CMakeFiles/main.dir/build.make:90: CMakeFiles/main.dir/src/static_centerline_generator_node.cpp.o] Error 1 <command-line>: fatal error: grid_map_core/eigen_plugins/FunctorsPlugin.hpp: No such file or directory compilation terminated. gmake[2]: *** [CMakeFiles/main.dir/build.make:76: CMakeFiles/main.dir/src/main.cpp.o] Error 1 gmake[1]: *** [CMakeFiles/Makefile2:625: CMakeFiles/main.dir/all] Error 2

This is caused by defining EIGEN_DENSEBASE_PLUGIN by grid_map_ros.
EIGEN_DENSEBASE_PLUGIN affects Eigen behavior, and caues build error.
grid_map_ros is an indirect dependency of static_centerline_generator, but does not appear in include directory of static_centerline_generator.

github-actions · 2024-06-27T23:47:13Z

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

You've checked our contribution guidelines.
Your PR follows our pull request guidelines.
All required CI checks pass before marking the PR ready for review.

…-deps

SakodaShintaro · 2024-08-05T04:53:52Z

Thank you for your pull request.
For the localization component, it seems to be fine, but there is a conflict in localization/pose_instability_detector/package.xml.
Also, if you submit pull requests for each component separately, it may be easier to review and merge them.

Shin-kyoto · 2024-08-13T07:05:05Z

Thank you for your PR!
Please resolve conflicts.

Shin-kyoto · 2024-08-20T03:44:30Z

@f0reachARR
Thank you for creating the PR.
Would it be possible for you to resolve the conflicts?

To keep Autoware healthy, we close PRs if there is no response for more than a week after requesting conflict resolution. If this PR is still active, please let us know. Even if this PR is closed, you are welcome to reopen it once the conflicts have been resolved.

HansRobo · 2024-08-20T05:06:25Z

@Shin-kyoto Thank you for friendly ping!
This PR is still alive but the auther is taking some time off.
So, you have any requests or comments, please mention me.

The status of this PR is currently under investigation for an unclear point discussed here.

To make this status easier to understand, I have marked the PR as draft.

Shin-kyoto · 2024-08-20T05:11:05Z

@Shin-kyoto Thank you for friendly ping! This PR is still alive but the auther is taking some time off. So, you have any requests or comments, please mention me.

The status of this PR is currently under investigation for an unclear point discussed here.

To make this status easier to understand, I have marked the PR as draft.

Thank you very much for telling the situation of this PR!!
We understand the situation 👍
Please feel free to make this PR open after the author came back.

f0reachARR · 2024-10-10T05:21:37Z

Sorry for late reply.
Now I can resolve conflicts, however it requires many approval to merge this PR.
I would like to close this PR, and split this PR by each components (like sensing, perception). Is this OK?

Add missing dependency for ament_index_cpp

4191b81

Signed-off-by: f0reachARR <f0reach@f0reach.me>

HansRobo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 20, 2024

pre-commit-ci bot and others added 2 commits June 20, 2024 06:00

style(pre-commit): autofix

26d899c

Fix grid_map deps

f36a306

Signed-off-by: f0reachARR <f0reach@f0reach.me>

f0reachARR requested review from zusizusi and mkquda as code owners June 20, 2024 06:13

style(pre-commit): autofix

88cb37c

HansRobo enabled auto-merge (squash) June 20, 2024 06:30

mitsudome-r reviewed Jun 20, 2024

View reviewed changes

Merge branch 'main' into fix/ament-index-cpp-deps

204b60a

Merge remote-tracking branch 'upstream/main' into fix/ament-index-cpp…

8ebcd0a

…-deps

auto-merge was automatically disabled July 19, 2024 02:39
Head branch was pushed to by a user without write access

Merge remote-tracking branch 'upstream/main' into fix/ament-index-cpp…

40b7505

…-deps

f0reachARR force-pushed the fix/ament-index-cpp-deps branch from 0d811fd to 40b7505 Compare July 25, 2024 04:44

style(pre-commit): autofix

b70a5b1

vividf assigned f0reachARR Aug 16, 2024

HansRobo marked this pull request as draft August 20, 2024 04:52

Shin-kyoto assigned HansRobo and unassigned f0reachARR Aug 20, 2024

f0reachARR closed this Oct 10, 2024

This was referenced Oct 10, 2024

fix: missing dependency in common components #9072

Merged

fix(control): missing dependency in control components #9073

Merged

fix(evaluator): missing dependency in evaluator components #9074

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: missing dependency for Jazzy #7600

fix: missing dependency for Jazzy #7600

f0reachARR commented Jun 20, 2024 •

edited by SakodaShintaro

Loading

codecov bot commented Jun 20, 2024 •

edited

Loading

mitsudome-r Jun 20, 2024

f0reachARR Jul 12, 2024

github-actions bot commented Jun 27, 2024 •

edited

Loading

SakodaShintaro commented Aug 5, 2024

Shin-kyoto commented Aug 13, 2024 •

edited

Loading

Shin-kyoto commented Aug 20, 2024

HansRobo commented Aug 20, 2024

Shin-kyoto commented Aug 20, 2024 •

edited

Loading

f0reachARR commented Oct 10, 2024

fix: missing dependency for Jazzy #7600

fix: missing dependency for Jazzy #7600

Conversation

f0reachARR commented Jun 20, 2024 • edited by SakodaShintaro Loading

Description

Tests performed

Effects on system behavior

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov bot commented Jun 20, 2024 • edited Loading

Codecov Report

mitsudome-r Jun 20, 2024

Choose a reason for hiding this comment

f0reachARR Jul 12, 2024

Choose a reason for hiding this comment

github-actions bot commented Jun 27, 2024 • edited Loading

SakodaShintaro commented Aug 5, 2024

Shin-kyoto commented Aug 13, 2024 • edited Loading

Shin-kyoto commented Aug 20, 2024

HansRobo commented Aug 20, 2024

Shin-kyoto commented Aug 20, 2024 • edited Loading

f0reachARR commented Oct 10, 2024

f0reachARR commented Jun 20, 2024 •

edited by SakodaShintaro

Loading

codecov bot commented Jun 20, 2024 •

edited

Loading

github-actions bot commented Jun 27, 2024 •

edited

Loading

Shin-kyoto commented Aug 13, 2024 •

edited

Loading

Shin-kyoto commented Aug 20, 2024 •

edited

Loading