Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(detected_object_validation): add test #7599

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jun 20, 2024

Description

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

kminoda added 2 commits June 20, 2024 14:00
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda changed the title feat(detected_object_validatio): add test feat(detected_object_validation): add test Jun 20, 2024
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Jun 20, 2024
@github-actions github-actions bot removed the component:common Common packages from the autoware-common repository. (auto-assigned) label Jun 20, 2024
@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.

Project coverage is 2.92%. Comparing base (507e3f4) to head (89ff59e).
Report is 86 commits behind head on main.

Current head 89ff59e differs from pull request most recent head ea936d9

Please upload reports for the commit ea936d9 to get more accurate results.

Files Patch % Lines
...ct_position_filter/test_object_position_filter.cpp 96.07% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7599       +/-   ##
==========================================
- Coverage   14.84%   2.92%   -11.93%     
==========================================
  Files        1999      85     -1914     
  Lines      139163    4170   -134993     
  Branches    43716     371    -43345     
==========================================
- Hits        20661     122    -20539     
+ Misses      95731    4030    -91701     
+ Partials    22771      18    -22753     
Flag Coverage Δ
differential 2.92% <96.07%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda
Copy link
Contributor Author

kminoda commented Jun 20, 2024

@badai-nguyen Hi, would you review this PR?

@kminoda kminoda marked this pull request as ready for review June 20, 2024 08:09
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda enabled auto-merge (squash) June 20, 2024 14:18
kminoda and others added 2 commits June 21, 2024 09:52
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda merged commit 21b0285 into autowarefoundation:main Jun 21, 2024
24 checks passed
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants