-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(static_obstacle_avoidance): keep object clipping even after the object becomes non-target #7591
feat(static_obstacle_avoidance): keep object clipping even after the object becomes non-target #7591
Conversation
…object becomes non-target Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
2d06a29
to
efaefb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7591 +/- ##
===========================================
- Coverage 14.84% 13.71% -1.13%
===========================================
Files 1999 254 -1745
Lines 139163 26422 -112741
Branches 43716 5156 -38560
===========================================
- Hits 20661 3625 -17036
+ Misses 95731 22272 -73459
+ Partials 22771 525 -22246
☔ View full report in Codecov by Sentry. |
…object becomes non-target (autowarefoundation#7591) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
…object becomes non-target (autowarefoundation#7591) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…object becomes non-target (#7591) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…object becomes non-target (autowarefoundation#7591) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Description
Memolize clip target object even after the object becoms non-target in order to prevent drivable boundary from changing suddenly. (Clip: exclude drivable area based on object polygon.)
Additionally, I organized config file to select avoidance path generation method easiliy.
This movie shows the avoidance maneuver when I set this param to
both
.simplescreenrecorder-2024-06-19_18.03.13.mp4
Tests performed
Effects on system behavior
Nothing. (By default, this module uses only
shift_line_based
path generation method.)Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.