Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(static_obstacle_avoidance): keep object clipping even after the object becomes non-target #7591

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jun 19, 2024

Description

⚠️ Please review autowarefoundation/autoware_launch#1036 at first.

Memolize clip target object even after the object becoms non-target in order to prevent drivable boundary from changing suddenly. (Clip: exclude drivable area based on object polygon.)

Additionally, I organized config file to select avoidance path generation method easiliy.

      # path generation method. select "shift_line_base" or "optimization_base" or "both".
      # "shift_line_base"  : Create avoidance path based on shift line.
      #                      User can control avoidance maneuver execution via RTC.
      #                      However, this method doesn't support complex avoidance scenario (e.g. S-shape maneuver).
      # "optimization_base": This module selects avoidance target object
      #                      and bpp module clips drivable area based on avoidance target object polygon shape.
      #                      But this module doesn't modify the path shape.
      #                      On the other hand, autoware_path_optimizer module optimizes path shape instead of this module
      #                      so that the path can be within drivable area. This method is able to deal with complex avoidance scenario.
      #                      However, user can't control avoidance manuever execution.
      # "both"             : Use both method.
      path_generation_method: "shift_line_base"

This movie shows the avoidance maneuver when I set this param to both.

simplescreenrecorder-2024-06-19_18.03.13.mp4

Tests performed

Effects on system behavior

Nothing. (By default, this module uses only shift_line_based path generation method.)

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 19, 2024
…object becomes non-target

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Copy link
Contributor

@go-sakayori go-sakayori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 16.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 13.71%. Comparing base (507e3f4) to head (efaefb6).
Report is 78 commits behind head on main.

Files Patch % Lines
...ath_static_obstacle_avoidance_module/src/utils.cpp 11.76% 14 Missing and 1 partial ⚠️
...ath_static_obstacle_avoidance_module/src/scene.cpp 16.66% 5 Missing ⚠️
...ath_static_obstacle_avoidance_module/src/debug.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7591       +/-   ##
===========================================
- Coverage   14.84%   13.71%    -1.13%     
===========================================
  Files        1999      254     -1745     
  Lines      139163    26422   -112741     
  Branches    43716     5156    -38560     
===========================================
- Hits        20661     3625    -17036     
+ Misses      95731    22272    -73459     
+ Partials    22771      525    -22246     
Flag Coverage Δ
differential 13.71% <16.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit 7638fa1 into autowarefoundation:main Jun 20, 2024
50 of 52 checks passed
@satoshi-ota satoshi-ota deleted the feat/keep-clip-object branch June 20, 2024 08:43
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
…object becomes non-target (autowarefoundation#7591)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jul 8, 2024
…object becomes non-target (autowarefoundation#7591)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…object becomes non-target (#7591)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jul 29, 2024
…object becomes non-target (autowarefoundation#7591)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants