Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_behavior_path_start_planner_module): fix duplicateBreak warning #7583

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Jun 19, 2024

Description

This is a fix based on cppcheck duplicateBreak warning

planning/behavior_path_planner/autoware_behavior_path_start_planner_module/src/start_planner_module.cpp:905:3: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak]
  return order_priority;
  ^

This modification is just to avoid cppcheck warnings.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…warning

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 19, 2024
@veqcc veqcc added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (507e3f4) to head (9f11272).
Report is 54 commits behind head on main.

Files Patch % Lines
..._start_planner_module/src/start_planner_module.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7583       +/-   ##
==========================================
- Coverage   14.84%   0.00%   -14.85%     
==========================================
  Files        1999     240     -1759     
  Lines      139163   22383   -116780     
  Branches    43716    2802    -40914     
==========================================
- Hits        20661       0    -20661     
+ Misses      95731   22383    -73348     
+ Partials    22771       0    -22771     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veqcc veqcc merged commit 8dcddae into autowarefoundation:main Jun 19, 2024
38 of 40 checks passed
@veqcc veqcc deleted the fix_duplicate_break_warning branch June 19, 2024 09:28
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
…warning (autowarefoundation#7583)

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…warning (#7583)

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants