Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_freespace_planning_algorithms): fix unusedScopedObject bug #7562

Merged

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Jun 18, 2024

Description

This is a fix based on cppcheck unusedScopedObject warning

planning/autoware_freespace_planning_algorithms/src/abstract_algorithm.cpp:94:10: style: Instance of 'std::runtime_error' object is destroyed immediately. [unusedScopedObject]
    std::runtime_error("cannot compute cost because waypoint has size 0");
         ^

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 18, 2024
@veqcc veqcc added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 15.30%. Comparing base (507e3f4) to head (4b3612a).
Report is 49 commits behind head on main.

Files Patch % Lines
...ace_planning_algorithms/src/abstract_algorithm.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7562      +/-   ##
==========================================
+ Coverage   14.84%   15.30%   +0.45%     
==========================================
  Files        1999      528    -1471     
  Lines      139163    48964   -90199     
  Branches    43716    12228   -31488     
==========================================
- Hits        20661     7493   -13168     
+ Misses      95731    40449   -55282     
+ Partials    22771     1022   -21749     
Flag Coverage Δ
differential 15.30% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veqcc veqcc merged commit 978d07d into autowarefoundation:main Jun 20, 2024
39 of 40 checks passed
@veqcc veqcc deleted the fix_unused_scoped_object_warning branch June 20, 2024 09:28
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
…ug (autowarefoundation#7562)

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…ug (#7562)

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants