Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autonomous_emergency_braking): add predicted object support for aeb #7548

Conversation

danielsanchezaran
Copy link
Contributor

Description

This PR introduces support for using predicted objects on AEB collision checking. It also enables toggling on and off pointcloud based and predicted object based collision checking.

Related links

Tests performed

PSim

The attached video shows the predicted object usage alongside the usual pointcloud method, I also turn off the point cloud method while the ego is moving and detecting an obstacle, and there is no problem with the transition.

cap-.2024-06-18-11-52-33.mp4

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jun 18, 2024
@danielsanchezaran danielsanchezaran force-pushed the feat/add-predicted-object-support-for-aeb branch from 723ad9b to dfdb08c Compare June 18, 2024 03:25
@github-actions github-actions bot removed the type:documentation Creating or refining documentation. (auto-assigned) label Jun 18, 2024
@danielsanchezaran danielsanchezaran marked this pull request as ready for review June 18, 2024 03:27
@danielsanchezaran danielsanchezaran added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 133 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (507e3f4) to head (3aa8706).
Report is 54 commits behind head on main.

Files Patch % Lines
...autoware_autonomous_emergency_braking/src/node.cpp 0.00% 72 Missing ⚠️
...utoware_autonomous_emergency_braking/src/utils.cpp 0.00% 57 Missing ⚠️
...ude/autoware/autonomous_emergency_braking/node.hpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7548       +/-   ##
==========================================
- Coverage   14.84%   0.00%   -14.85%     
==========================================
  Files        1999     118     -1881     
  Lines      139163   12760   -126403     
  Branches    43716    1377    -42339     
==========================================
- Hits        20661       0    -20661     
+ Misses      95731   12760    -82971     
+ Partials    22771       0    -22771     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielsanchezaran danielsanchezaran force-pushed the feat/add-predicted-object-support-for-aeb branch 2 times, most recently from c683a55 to f3bd253 Compare June 18, 2024 08:29
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@danielsanchezaran danielsanchezaran force-pushed the feat/add-predicted-object-support-for-aeb branch from cb8cee6 to 6d14e84 Compare June 19, 2024 03:07
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@danielsanchezaran danielsanchezaran merged commit 51045e9 into autowarefoundation:main Jun 19, 2024
27 of 30 checks passed
@danielsanchezaran danielsanchezaran deleted the feat/add-predicted-object-support-for-aeb branch June 19, 2024 08:04
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
…aeb (autowarefoundation#7548)

* add polling sub to predicted objects

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* WIP requires changing path frame to map

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add parameters and reuse predicted obj speed

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* introduce early break to reduce computation time

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* resolve merge conflicts

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix guard

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* remove unused declaration

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix include

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix include issues

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* remove inline

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* delete unused dependencies

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add utils.cpp

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* remove _ for non member variable

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…aeb (#7548)

* add polling sub to predicted objects

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* WIP requires changing path frame to map

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add parameters and reuse predicted obj speed

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* introduce early break to reduce computation time

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* resolve merge conflicts

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix guard

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* remove unused declaration

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix include

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix include issues

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* remove inline

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* delete unused dependencies

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add utils.cpp

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* remove _ for non member variable

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Sep 11, 2024
…aeb (autowarefoundation#7548)

* add polling sub to predicted objects

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* WIP requires changing path frame to map

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add parameters and reuse predicted obj speed

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* introduce early break to reduce computation time

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* resolve merge conflicts

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix guard

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* remove unused declaration

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix include

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix include issues

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* remove inline

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* delete unused dependencies

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add utils.cpp

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* remove _ for non member variable

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Oct 28, 2024
…aeb (autowarefoundation#7548)

* add polling sub to predicted objects

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* WIP requires changing path frame to map

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add parameters and reuse predicted obj speed

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* introduce early break to reduce computation time

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* resolve merge conflicts

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix guard

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* remove unused declaration

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix include

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix include issues

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* remove inline

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* delete unused dependencies

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add utils.cpp

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* remove _ for non member variable

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Nov 14, 2024
…aeb (autowarefoundation#7548)

* add polling sub to predicted objects

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* WIP requires changing path frame to map

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add parameters and reuse predicted obj speed

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* introduce early break to reduce computation time

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* resolve merge conflicts

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix guard

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* remove unused declaration

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix include

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix include issues

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* remove inline

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* delete unused dependencies

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add utils.cpp

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* remove _ for non member variable

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants