-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autonomous_emergency_braking): add predicted object support for aeb #7548
Merged
danielsanchezaran
merged 13 commits into
autowarefoundation:main
from
tier4:feat/add-predicted-object-support-for-aeb
Jun 19, 2024
Merged
feat(autonomous_emergency_braking): add predicted object support for aeb #7548
danielsanchezaran
merged 13 commits into
autowarefoundation:main
from
tier4:feat/add-predicted-object-support-for-aeb
Jun 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:documentation
Creating or refining documentation. (auto-assigned)
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
labels
Jun 18, 2024
danielsanchezaran
force-pushed
the
feat/add-predicted-object-support-for-aeb
branch
from
June 18, 2024 03:25
723ad9b
to
dfdb08c
Compare
github-actions
bot
removed
the
type:documentation
Creating or refining documentation. (auto-assigned)
label
Jun 18, 2024
danielsanchezaran
requested review from
TakaHoribe,
takayuki5168,
soblin and
tkimura4
as code owners
June 18, 2024 03:27
danielsanchezaran
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jun 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7548 +/- ##
==========================================
- Coverage 14.84% 0.00% -14.85%
==========================================
Files 1999 118 -1881
Lines 139163 12760 -126403
Branches 43716 1377 -42339
==========================================
- Hits 20661 0 -20661
+ Misses 95731 12760 -82971
+ Partials 22771 0 -22771
☔ View full report in Codecov by Sentry. |
danielsanchezaran
force-pushed
the
feat/add-predicted-object-support-for-aeb
branch
2 times, most recently
from
June 18, 2024 08:29
c683a55
to
f3bd253
Compare
soblin
reviewed
Jun 18, 2024
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran
force-pushed
the
feat/add-predicted-object-support-for-aeb
branch
from
June 19, 2024 03:07
cb8cee6
to
6d14e84
Compare
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
soblin
approved these changes
Jun 19, 2024
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
takayuki5168
approved these changes
Jun 19, 2024
4 tasks
danielsanchezaran
merged commit Jun 19, 2024
51045e9
into
autowarefoundation:main
27 of 30 checks passed
simon-eisenmann-driveblocks
pushed a commit
to simon-eisenmann-driveblocks/autoware.universe
that referenced
this pull request
Jun 26, 2024
…aeb (autowarefoundation#7548) * add polling sub to predicted objects Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * WIP requires changing path frame to map Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add parameters and reuse predicted obj speed Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * introduce early break to reduce computation time Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * resolve merge conflicts Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * fix guard Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove unused declaration Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * fix include Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * fix include issues Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove inline Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * delete unused dependencies Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add utils.cpp Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove _ for non member variable Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…aeb (#7548) * add polling sub to predicted objects Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * WIP requires changing path frame to map Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add parameters and reuse predicted obj speed Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * introduce early break to reduce computation time Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * resolve merge conflicts Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * fix guard Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove unused declaration Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * fix include Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * fix include issues Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove inline Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * delete unused dependencies Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add utils.cpp Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove _ for non member variable Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 11, 2024
…aeb (autowarefoundation#7548) * add polling sub to predicted objects Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * WIP requires changing path frame to map Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add parameters and reuse predicted obj speed Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * introduce early break to reduce computation time Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * resolve merge conflicts Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * fix guard Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove unused declaration Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * fix include Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * fix include issues Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove inline Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * delete unused dependencies Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add utils.cpp Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove _ for non member variable Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 28, 2024
…aeb (autowarefoundation#7548) * add polling sub to predicted objects Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * WIP requires changing path frame to map Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add parameters and reuse predicted obj speed Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * introduce early break to reduce computation time Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * resolve merge conflicts Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * fix guard Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove unused declaration Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * fix include Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * fix include issues Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove inline Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * delete unused dependencies Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add utils.cpp Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove _ for non member variable Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran
added a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 14, 2024
…aeb (autowarefoundation#7548) * add polling sub to predicted objects Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * WIP requires changing path frame to map Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add parameters and reuse predicted obj speed Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * introduce early break to reduce computation time Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * resolve merge conflicts Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * fix guard Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove unused declaration Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * fix include Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * fix include issues Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove inline Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * delete unused dependencies Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add utils.cpp Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove _ for non member variable Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces support for using predicted objects on AEB collision checking. It also enables toggling on and off pointcloud based and predicted object based collision checking.
Related links
Tests performed
PSim
The attached video shows the predicted object usage alongside the usual pointcloud method, I also turn off the point cloud method while the ego is moving and detecting an obstacle, and there is no problem with the transition.
cap-.2024-06-18-11-52-33.mp4
Notes for reviewers
Interface changes
ROS Topic Changes
ROS Parameter Changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.