refactor(accel_brake_map_calibrator)!: add autoware_ prefix #7351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:documentation
yuki-takagi-66
added
the
run:build-and-test-differential
yuki-takagi-66
requested review from
mkuri,
taikitanaka3,
TakaHoribe,
1222-takeshi and
tkimura4
as code owners
yuki-takagi-66
force-pushed
the
prefix-accel_brake_map_calibrator
branch
from
be271cd to
5d5b4cc
Compare
yuki-takagi-66
requested review from
satoshi-ota,
miursh and
tzhong518
as code owners
github-actions
bot
added
component:perception
|
This PR works well for one week ago. I'll confirm the rebased version by the morning |
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> change dir name Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> update Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> update Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
yuki-takagi-66
force-pushed
the
prefix-accel_brake_map_calibrator
branch
from
8d16be6 to
791953b
Compare
github-actions
bot
added
the
component:perception
takayuki5168
approved these changes
Jun 10, 2024
4 tasks
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* add prefix to the codes Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> change dir name Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> update Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> update Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * delete debug Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * fix format Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * fix format Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * restore Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * poi Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> --------- Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
autoware_prefix toaccel_brake_map_calibrator.Part of:
Related links
autowarefoundation/autoware#4569
Tests performed
We confirmed that the calibrated data can be generated properly from rosbag in cherry-pick before the breaking msg type change.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.