refactor(probabilistic_occupancy_grid_map): rework parameters #7339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:documentation
|
@tby-udel Thanks for the PR. However, the PR seems to be failing in the CI for DCO check. When you push commits, could you push with signed-off commits? For example by running the following command: |
tby-udel
force-pushed
the
traffic-light-visualization-branch
branch
from
11bebcd to
4b9c4a3
Compare
|
Thank you for the reminder, I have pushed the signed off commit. |
mitsudome-r
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7339 +/- ##
=======================================
Coverage 28.94% 28.94%
=======================================
Files 1600 1600
Lines 117215 117183 -32
Branches 50291 50269 -22
=======================================
- Hits 33930 33921 -9
+ Misses 74125 74103 -22
+ Partials 9160 9159 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mitsudome-r
reviewed
Jun 27, 2024
Comment on lines
5
to
6
| "properties": { | ||
| "ros__parameters": { |
There was a problem hiding this comment.
The CI is complaining about the syntax in this file.
I think the properties should start with /** as required field, but it is now starting with ros__parameters
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
|
The required changes have been made. |
Signed-off-by: Boyang <tby@udel.edu>
Signed-off-by: Boyang <tby@udel.edu>
mitsudome-r
force-pushed
the
traffic-light-visualization-branch
branch
from
08c77ca to
96ff2bb
Compare
yhisaki
pushed a commit
to yhisaki/autoware.universe
that referenced
this pull request
Jul 19, 2024
…refoundation#7339) * refactor(probabilistic_occupancy_grid_map): rework parameters Signed-off-by: Boyang <tby@udel.edu> * style(pre-commit): autofix * Solved the CI's complainment Signed-off-by: Boyang <tby@udel.edu> --------- Signed-off-by: Boyang <tby@udel.edu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Ariiees
pushed a commit
to Ariiees/autoware.universe
that referenced
this pull request
Jul 22, 2024
…refoundation#7339) * refactor(probabilistic_occupancy_grid_map): rework parameters Signed-off-by: Boyang <tby@udel.edu> * style(pre-commit): autofix * Solved the CI's complainment Signed-off-by: Boyang <tby@udel.edu> --------- Signed-off-by: Boyang <tby@udel.edu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
chihungtzeng
pushed a commit
to chihungtzeng/autoware.universe
that referenced
this pull request
Jul 23, 2024
…refoundation#7339) * refactor(probabilistic_occupancy_grid_map): rework parameters Signed-off-by: Boyang <tby@udel.edu> * style(pre-commit): autofix * Solved the CI's complainment Signed-off-by: Boyang <tby@udel.edu> --------- Signed-off-by: Boyang <tby@udel.edu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: chtseng <chtseng@itri.org.tw>
esteve
pushed a commit
to esteve/autoware.universe
that referenced
this pull request
Aug 13, 2024
…refoundation#7339) * refactor(probabilistic_occupancy_grid_map): rework parameters Signed-off-by: Boyang <tby@udel.edu> * style(pre-commit): autofix * Solved the CI's complainment Signed-off-by: Boyang <tby@udel.edu> --------- Signed-off-by: Boyang <tby@udel.edu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the
probabilistic_occupancy_grid_mappackage.Tests performed
Package built and launched locally.
Notes for reviewers
Nothing inside the src code part was changed, only taking the parameters out.
Interface changes
Parameter values are now required to be passed to the node when launched.
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.