Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add faster ament_cmake to build_depends.repos #7317

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Jun 6, 2024

Description

This makes the same change that we made to autoware.repos in autoware repository in this PR.

This should make the build faster in the build-and-test CI. For the details, please check the above PR.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 6, 2024
@mitsudome-r mitsudome-r enabled auto-merge (squash) June 6, 2024 09:41
@mitsudome-r
Copy link
Member Author

I'm checking how fast it can run build-and-test in this workflow: https://github.com/autowarefoundation/autoware.universe/actions/runs/9399133982

@mitsudome-r mitsudome-r disabled auto-merge June 6, 2024 10:18
@xmfcx
Copy link
Contributor

xmfcx commented Jun 6, 2024

I can't believe we've missed this.
Works twice as fast.

image

@xmfcx xmfcx merged commit 5d9fa04 into autowarefoundation:main Jun 6, 2024
25 of 41 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jun 6, 2024
…ndation#7317)

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants